You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2017/08/22 01:34:32 UTC
[GitHub] nifi pull request #2105: NIFI-4169: WIP PutWebSocket broadcast failure handl...
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2105
NIFI-4169: WIP PutWebSocket broadcast failure handling
**NOTE**
Submitting this PR just for code review purpose. Not ready to be merged yet.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4169
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2105
----
commit 8ca63ae87b0dfe6c44f9d1f0ef86167968df26cd
Author: Koji Kawamura <ij...@apache.org>
Date: 2017-08-21T22:47:23Z
Contribution from Y Wikander.
commit 2f0dfe1be9df4e59d3128924d386d382fb1850b1
Author: Koji Kawamura <ij...@apache.org>
Date: 2017-08-22T01:30:37Z
NIFI-4169: WIP PutWebSocket broadcast failure handling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2105: NIFI-4169: Enhance PutWebSocket error handling
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2105
This PR is now ready to get reviewed.
A flow template is available here for testing both NiFi as a WebSocket client and server.
https://gist.github.com/ijokarumawak/f36668b193bc413da3e0d968bb6b47c1
This PR is based on the contribution from Y Wikander.
- Added "Fork Failed Broadcast Sessions" property to specify whether
failed FlowFiles should be forked and transferred individually so that
user can construct a error handling flow using each session id.
- Added "Enable Detailed Failure Relationships" property to separate
failure routes into more detailed ones, such as 'no connected sessions'
or 'communication failure'
- Added "websocket.broadcast.succeeded" and "websocket.broadcast.failed"
attributes to outgoing FlowFiles when a message is broadcast.
---