[jira] [Commented] (SYNCOPE-460) Default datasource uses BasicDataSource

["Francesco Chicchiriccò (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNCOPE-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855498#comment-13855498 ] 

Francesco Chicchiriccò commented on SYNCOPE-460:
------------------------------------------------

Hi [~wimmelg],
thanks for your updated patch.

I had no problems in running the whole test suite with H2, but with both MySQL (InnoDB) and PotsgreSQL I had:
 # a test failure
{code}
executeAndExport(org.apache.syncope.core.rest.ReportTestITCase)  Time elapsed: 1.216 sec  <<< ERROR!
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
	at java.util.ArrayList.rangeCheck(ArrayList.java:604)
	at java.util.ArrayList.get(ArrayList.java:382)
	at org.apache.syncope.core.rest.ReportTestITCase.executeAndExport(ReportTestITCase.java:189)
{code}
 # long time for completion: usually it takes ~3 minutes on my laptop for running the whole test suite but with the updated patch times are > 10 minutes

I haven't tried yet with Oracle or MS SQL Server.

> Default datasource uses BasicDataSource
> ---------------------------------------
>
>                 Key: SYNCOPE-460
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-460
>             Project: Syncope
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.1.5
>            Reporter: Oliver Wulff
>            Assignee: Francesco Chicchiriccò
>            Priority: Minor
>             Fix For: 1.1.6, 1.2.0
>
>         Attachments: patch.git, syncope-460_20121220.patch
>
>
> Replace org.springframework.jdbc.datasource.DriverManagerDataSource by org.apache.commons.dbcp.BasicDataSource as recommended by spring:
> http://docs.spring.io/spring/docs/current/spring-framework-reference/html/jdbc.html#jdbc-connections
> Make property "isolationLevelName" configurable in persistence.properties with default ISOLATION_READ_COMMITTED
> See full discussion in dev@ ML: http://markmail.org/message/33aheawb5irzl3xc



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)