You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2011/03/04 15:38:35 UTC

[Bug 6548] New: spamd protocol examples are wrong

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

           Summary: spamd protocol examples are wrong
           Product: Spamassassin
           Version: 3.3.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Documentation
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: lemke@jam-software.com
                CC: jm@jmason.org


Looks like the examples for reporting and revoking a message in the spamd
protocol documentation are wrong.

See this discussion for more information: 
http://old.nabble.com/SpamAssassin-protocol-examples-to31001608.html#a31068134

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] [review] [doc] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|spamd protocol examples are |[review] [doc] spamd
                   |wrong                       |protocol examples are wrong
  Status Whiteboard|                            |needs 2 votes for 3.3.2

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

--- Comment #4 from Daniel Lemke <le...@jam-software.com> 2011-03-18 06:53:29 EDT ---
Any chance to commit this one?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

--- Comment #2 from Daniel Lemke <le...@jam-software.com> 2011-03-09 02:59:14 EST ---
Created an attachment (id=4848)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4848)
patch to correct spamd protocol examples

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: [Bug 6548] [review] [doc] spamd protocol examples are wrong

Posted by Karsten Bräckelmann <gu...@rudersport.de>.
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548
> > Though did you really have to remove the trailing newline, Mark? I like
> > trailing newlines. ;)
> 
> trunk:
>   [doc] re-append an empty line to spamd/PROTOCOL, Guenther liked it :)
> Sending spamd/PROTOCOL
> Committed revision 1084826.

FOCROFL

A minute later... Haven't used that acronym in quite a while [1]. Thanks
Mark. I probably should get my name handle straight some day. History
repeats itself. Some are referring to me as guenther, some as Karsten.


[1] I believe, since BBS times.

-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}


[Bug 6548] [review] [doc] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

--- Comment #7 from Mark Martinec <Ma...@ijs.si> 2011-03-23 21:25:13 EDT ---
> Though did you really have to remove the trailing newline, Mark? I like
> trailing newlines. ;)

trunk:
  [doc] re-append an empty line to spamd/PROTOCOL, Guenther liked it :)
Sending spamd/PROTOCOL
Committed revision 1084826.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

--- Comment #1 from Karsten Bräckelmann <gu...@rudersport.de> 2011-03-04 12:58:27 EST ---
Also see bug 5398 and revision 528556, which appears to have changed a
different header / protocol example than reported.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

Daniel Lemke <le...@jam-software.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lemke@jam-software.com

--- Comment #3 from Daniel Lemke <le...@jam-software.com> 2011-03-09 03:00:47 EST ---
(In reply to comment #1)
> Also see bug 5398 and revision 528556, which appears to have changed a
> different header / protocol example than reported.

Yes, that's the reason I put Justin on cc, I guess this was a small mistake.

I attached a patch to correct the examples.

Daniel

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] [review] [doc] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

Karsten Bräckelmann <gu...@rudersport.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|needs 2 votes for 3.3.2     |needs 1 vote for 3.3.2

--- Comment #6 from Karsten Bräckelmann <gu...@rudersport.de> 2011-03-23 00:54:46 EDT ---
Hmm... Looks good to me, makes a hell of a lot more sense. Thanks, Daniel.
Though did you really have to remove the trailing newline, Mark? I like
trailing newlines. ;)

+1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.3.2

--- Comment #5 from Mark Martinec <Ma...@ijs.si> 2011-03-22 22:11:25 EDT ---
> Any chance to commit this one?

+1  thanks for noticing and fixing the documentation bug

trunk:
  Bug 6548: spamd protocol examples are wrong' spamd/PROTOCOL
Sending  spamd/PROTOCOL
Committed revision 1084457.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] [review] [doc] spamd protocol examples are wrong

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Mark Martinec <Ma...@ijs.si> 2011-05-05 17:28:06 UTC ---
3.3:
  $ svn ci -m 'Bug 6548: spamd protocol examples are wrong'
  Sending spamd/PROTOCOL
Committed revision 1099882.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6548] [review] [doc] spamd protocol examples are wrong

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6548

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com
  Status Whiteboard|needs 1 vote for 3.3.2      |RTC for 3.3.2

--- Comment #8 from Kevin A. McGrail <km...@pccc.com> 2011-03-24 10:58:38 EDT ---
(In reply to comment #7)
> > Though did you really have to remove the trailing newline, Mark? I like
> > trailing newlines. ;)
> 
> trunk:
>   [doc] re-append an empty line to spamd/PROTOCOL, Guenther liked it :)
> Sending spamd/PROTOCOL
> Committed revision 1084826.

+1 for 3.3.2

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.