You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org> on 2006/08/29 19:00:22 UTC
[jira] Created: (DIRSERVER-723) Possible double add of
extensibleMatchFilter in filter tree
Possible double add of extensibleMatchFilter in filter tree
-----------------------------------------------------------
Key: DIRSERVER-723
URL: http://issues.apache.org/jira/browse/DIRSERVER-723
Project: Directory ApacheDS
Issue Type: Bug
Components: ldap
Reporter: Pierre-Arnaud Marcelot
In internal class "GrammarAction("Init extensible match Filter" )" (line 97), I think that the extensibleMatchFilter may be added twice in the Filter tree.
The following code add the Filter :
------------------
// Get the parent, if any
Filter currentFilter = searchRequest.getCurrentFilter();
if ( currentFilter != null )
{
// Ok, we have a parent. The new Filter will be added to
// this parent, then.
( ( ConnectorFilter ) currentFilter ).addFilter( extensibleMatchFilter );
extensibleMatchFilter.setParent( currentFilter );
}
else
{
// No parent. This Filter will become the root.
searchRequest.setFilter( extensibleMatchFilter );
extensibleMatchFilter.setParent( searchRequest );
}
------------------
and then, the addCurrentFilter( extensibleMatchFilter ) method is called and does the same thing another time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (DIRSERVER-723) Possible double add of
extensibleMatchFilter in filter tree
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRSERVER-723?page=all ]
Emmanuel Lecharny reassigned DIRSERVER-723:
-------------------------------------------
Assignee: Emmanuel Lecharny
> Possible double add of extensibleMatchFilter in filter tree
> -----------------------------------------------------------
>
> Key: DIRSERVER-723
> URL: http://issues.apache.org/jira/browse/DIRSERVER-723
> Project: Directory ApacheDS
> Issue Type: Bug
> Components: ldap
> Reporter: Pierre-Arnaud Marcelot
> Assigned To: Emmanuel Lecharny
>
> In internal class "GrammarAction("Init extensible match Filter" )" (line 97), I think that the extensibleMatchFilter may be added twice in the Filter tree.
> The following code add the Filter :
> ------------------
> // Get the parent, if any
> Filter currentFilter = searchRequest.getCurrentFilter();
> if ( currentFilter != null )
> {
> // Ok, we have a parent. The new Filter will be added to
> // this parent, then.
> ( ( ConnectorFilter ) currentFilter ).addFilter( extensibleMatchFilter );
> extensibleMatchFilter.setParent( currentFilter );
> }
> else
> {
> // No parent. This Filter will become the root.
> searchRequest.setFilter( extensibleMatchFilter );
> extensibleMatchFilter.setParent( searchRequest );
> }
> ------------------
> and then, the addCurrentFilter( extensibleMatchFilter ) method is called and does the same thing another time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DIRSERVER-723) Possible double add of
extensibleMatchFilter in filter tree
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRSERVER-723?page=all ]
Pierre-Arnaud Marcelot closed DIRSERVER-723.
--------------------------------------------
Great!
I'm closing the issue.
> Possible double add of extensibleMatchFilter in filter tree
> -----------------------------------------------------------
>
> Key: DIRSERVER-723
> URL: http://issues.apache.org/jira/browse/DIRSERVER-723
> Project: Directory ApacheDS
> Issue Type: Bug
> Components: ldap
> Reporter: Pierre-Arnaud Marcelot
> Assigned To: Emmanuel Lecharny
>
> In internal class "GrammarAction("Init extensible match Filter" )" (line 97), I think that the extensibleMatchFilter may be added twice in the Filter tree.
> The following code add the Filter :
> ------------------
> // Get the parent, if any
> Filter currentFilter = searchRequest.getCurrentFilter();
> if ( currentFilter != null )
> {
> // Ok, we have a parent. The new Filter will be added to
> // this parent, then.
> ( ( ConnectorFilter ) currentFilter ).addFilter( extensibleMatchFilter );
> extensibleMatchFilter.setParent( currentFilter );
> }
> else
> {
> // No parent. This Filter will become the root.
> searchRequest.setFilter( extensibleMatchFilter );
> extensibleMatchFilter.setParent( searchRequest );
> }
> ------------------
> and then, the addCurrentFilter( extensibleMatchFilter ) method is called and does the same thing another time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DIRSERVER-723) Possible double add of
extensibleMatchFilter in filter tree
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRSERVER-723?page=all ]
Emmanuel Lecharny resolved DIRSERVER-723.
-----------------------------------------
Resolution: Fixed
Whaoo !!! What a bug !
Thanks a lot for the find, I could have spend hours trying to find it later !
Fixed, the code has been removed.
> Possible double add of extensibleMatchFilter in filter tree
> -----------------------------------------------------------
>
> Key: DIRSERVER-723
> URL: http://issues.apache.org/jira/browse/DIRSERVER-723
> Project: Directory ApacheDS
> Issue Type: Bug
> Components: ldap
> Reporter: Pierre-Arnaud Marcelot
> Assigned To: Emmanuel Lecharny
>
> In internal class "GrammarAction("Init extensible match Filter" )" (line 97), I think that the extensibleMatchFilter may be added twice in the Filter tree.
> The following code add the Filter :
> ------------------
> // Get the parent, if any
> Filter currentFilter = searchRequest.getCurrentFilter();
> if ( currentFilter != null )
> {
> // Ok, we have a parent. The new Filter will be added to
> // this parent, then.
> ( ( ConnectorFilter ) currentFilter ).addFilter( extensibleMatchFilter );
> extensibleMatchFilter.setParent( currentFilter );
> }
> else
> {
> // No parent. This Filter will become the root.
> searchRequest.setFilter( extensibleMatchFilter );
> extensibleMatchFilter.setParent( searchRequest );
> }
> ------------------
> and then, the addCurrentFilter( extensibleMatchFilter ) method is called and does the same thing another time.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira