You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2024/01/16 02:54:25 UTC
[PR] Prepare for 0.12.0-rc2 [arrow-ballista]
andygrove opened a new pull request, #956:
URL: https://github.com/apache/arrow-ballista/pull/956
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-ballista/issues/926
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
0.12.0-rc1 failed because we are pinned to a non-release version of DataFusion. We will need to wait for the imminent 35.0.0 release.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Pin to newer version. I will update this PR once DF 35.0.0 is released.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare for 0.12.0-rc2 [arrow-ballista]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #956:
URL: https://github.com/apache/arrow-ballista/pull/956#discussion_r1466909606
##########
ballista/core/Cargo.toml:
##########
@@ -41,7 +41,6 @@ force_hash_collisions = ["datafusion/force_hash_collisions"]
hdfs = ["datafusion-objectstore-hdfs/hdfs"]
hdfs3 = ["datafusion-objectstore-hdfs/hdfs3"]
s3 = ["object_store/aws"]
-simd = ["datafusion/simd"]
Review Comment:
simd feature was removed from arrow-rs in:
```
commit d41e90e31d07bc2ad2f05ffc091f171e6c846ddf
Author: Raphael Taylor-Davies <17...@users.noreply.github.com>
Date: Fri Dec 8 08:49:46 2023 +0000
Remove SIMD Feature (#5184)
* Remove SIMD feature
* Clippy
* Tweak WASM features
* Fix test
* Exclude pyarrow from general build
```
There are commits prior to this with statements such as:
```
* Refactor numeric aggregation kernels to make better use of
auto-vectorization.
Remove the explicit simd implementations since the autovectorized
versions are faster on average.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare for 0.12.0-rc2 [arrow-ballista]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #956:
URL: https://github.com/apache/arrow-ballista/pull/956#issuecomment-1910457654
@avantgardnerio @Dandandan I plan on merging this when CI passes and will then cut a new RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare for 0.12.0-rc2 [arrow-ballista]
Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio commented on code in PR #956:
URL: https://github.com/apache/arrow-ballista/pull/956#discussion_r1466602590
##########
ballista/core/Cargo.toml:
##########
@@ -41,7 +41,6 @@ force_hash_collisions = ["datafusion/force_hash_collisions"]
hdfs = ["datafusion-objectstore-hdfs/hdfs"]
hdfs3 = ["datafusion-objectstore-hdfs/hdfs3"]
s3 = ["object_store/aws"]
-simd = ["datafusion/simd"]
Review Comment:
What happened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare for 0.12.0-rc2 [arrow-ballista]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #956:
URL: https://github.com/apache/arrow-ballista/pull/956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare for 0.12.0-rc2 [arrow-ballista]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #956:
URL: https://github.com/apache/arrow-ballista/pull/956#discussion_r1452876725
##########
ballista/core/Cargo.toml:
##########
@@ -41,7 +41,6 @@ force_hash_collisions = ["datafusion/force_hash_collisions"]
hdfs = ["datafusion-objectstore-hdfs/hdfs"]
hdfs3 = ["datafusion-objectstore-hdfs/hdfs3"]
s3 = ["object_store/aws"]
-simd = ["datafusion/simd"]
Review Comment:
DataFusion no longer has a simd feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org