You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/26 10:51:25 UTC

[GitHub] [rocketmq] ShadowySpirits commented on pull request #5554: [ISSUE #5553] Parallelize generating ConsumeQueue

ShadowySpirits commented on PR #5554:
URL: https://github.com/apache/rocketmq/pull/5554#issuecomment-1328023921

   Nice job! Looks like a great improvement. And I have some suggestions for your test.
   
   > 当并发线程较小时生成消息速度有所提升
   
   It sounds weird, if we use a single thread for lock-free and out-of-order dispatch, will we get better performance?
   
   > 原设计处于较后位置的消息会有一定延迟
   
   Can you record the dispatch latency (avg/pt90/pt99) to further illustrate the advantages of your solution?
   
   And dispatch is the core logic of RocketMQ, so it is necessary to use long-running tests to verify its stability, latency, and CPU usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org