You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/16 00:33:20 UTC

[GitHub] [druid] paul-rogers commented on pull request #12058: Response "trailer" support

paul-rogers commented on pull request #12058:
URL: https://github.com/apache/druid/pull/12058#issuecomment-995327640


   One of the steps failed in a unit test which appears due to flaky behavior:
   
   ```text
   [ERROR] testReconnectWithCacheAndPrefetch(org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest)  Time elapsed: 8.224 s  <<< ERROR!
   java.lang.RuntimeException: java.util.concurrent.TimeoutException
   	at org.apache.druid.data.input.impl.prefetch.Fetcher.openObjectFromLocal(Fetcher.java:226)
   	at org.apache.druid.data.input.impl.prefetch.Fetcher.next(Fetcher.java:177)
   	at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactory$2.next(PrefetchableTextFilesFirehoseFactory.java:239)
   	at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactory$2.next(PrefetchableTextFilesFirehoseFactory.java:225)
   	at org.apache.druid.data.input.impl.FileIteratingFirehose.getNextLineIterator(FileIteratingFirehose.java:105)
   	at org.apache.druid.data.input.impl.FileIteratingFirehose.hasMore(FileIteratingFirehose.java:66)
   	at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest.testReconnectWithCacheAndPrefetch(PrefetchableTextFilesFirehoseFactoryTest.java:356)
   ```
   
   Took a look a the test. The Firehose is completely separate from any of the areas I changed. Perhaps there is a race condition in the code, though brief inspection did not reveal the cause. The test works fine in Maven and in the IDE on my machine. Anyone seen this one fail previously? Added more detail to the exception in case if fails again. Let's not hold up reviews due to this test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org