You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "paulk-asert (via GitHub)" <gi...@apache.org> on 2026/10/21 03:35:22 UTC
[PR] groovy-lsp: publishDiagnostics could return before a concurrent publi… [groovy]
paulk-asert opened a new pull request, #2997:
URL: https://github.com/apache/groovy/pull/2997
…sher cleared removed URIs
This is to potentially fix the flakey test:
> GroovyLanguageServerTest > publishDiagnosticsIncludeVersionAndClearRemovedUris() FAILED
> Assertion failed:
>
> assert fixture.diagnostics[brokenUri] == []
> | | || |
> | | || false
> | | |'file:///tmp/groovy-lsp-drop13034844068705591508/Broken.groovy'
> | | [Diagnostic [
> | | range = Range [
> | | start = Position [
> | | line = 0
> | | character = 14
> | | ]
> | | end = Position [
> | | line = 0
> | | character = 14
> | | ]
> | | ]
> | | severity = Error
> | | code = null
> | | codeDescription = null
> | | source = "groovy"
> | | message = Either [
> | | left = Missing '}'
> | | right = null
> | | ]
> | | tags = null
> | | relatedInformation = null
> | | data = null
> | | ]]
> | ['file:///tmp/groovy-lsp-drop13034844068705591508/Broken.groovy':[], 'file:///home/runner/work/groovy/groovy/subprojects/groovy-lsp/Hello.groovy':[]]
> org.apache.groovy.lsp.internal.LspFixture@64ee9290
> at org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:409)
> at org.apache.groovy.lsp.GroovyLanguageServerTest.publishDiagnosticsIncludeVersionAndClearRemovedUris(GroovyLanguageServerTest.groovy:258)
>
>
> > Task :groovy-lsp:test FAILED
> 310 tests completed, 1 failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] groovy-lsp: publishDiagnostics could return before a concurrent publi… [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert merged PR #2997:
URL: https://github.com/apache/groovy/pull/2997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] groovy-lsp: publishDiagnostics could return before a concurrent publi… [groovy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2997:
URL: https://github.com/apache/groovy/pull/2997#issuecomment-6308397437
## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2997?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `94.44444%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 72.4268%. Comparing base ([`8778bce`](https://app.codecov.io/gh/apache/groovy/commit/8778bce1a0da05b5bffe27f02819262c849f9d56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4025f9d`](https://app.codecov.io/gh/apache/groovy/commit/4025f9dff6412d79d4780b7d391f0b5c72d0854e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2997?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...che/groovy/lsp/internal/LanguageServerContext.java](https://app.codecov.io/gh/apache/groovy/pull/2997?src=pr&el=tree&filepath=subprojects%2Fgroovy-lsp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Flsp%2Finternal%2FLanguageServerContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWxzcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2xzcC9pbnRlcm5hbC9MYW5ndWFnZVNlcnZlckNvbnRleHQuamF2YQ==) | 94.4444% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2997 +/- ##
==================================================
- Coverage 72.4290% 72.4268% -0.0022%
+ Complexity 40622 40620 -2
==================================================
Files 1643 1643
Lines 142686 142689 +3
Branches 26799 26799
==================================================
- Hits 103346 103345 -1
- Misses 29830 29831 +1
- Partials 9510 9513 +3
```
| [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2997?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...che/groovy/lsp/internal/LanguageServerContext.java](https://app.codecov.io/gh/apache/groovy/pull/2997?src=pr&el=tree&filepath=subprojects%2Fgroovy-lsp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Flsp%2Finternal%2FLanguageServerContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWxzcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2xzcC9pbnRlcm5hbC9MYW5ndWFnZVNlcnZlckNvbnRleHQuamF2YQ==) | `95.0226% <94.4444%> (+0.0685%)` | :arrow_up: |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2997/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] groovy-lsp: publishDiagnostics could return before a concurrent publi… [groovy]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #2997:
URL: https://github.com/apache/groovy/pull/2997#issuecomment-6309051249
## ✅ All tests passed ✅
🏷️ Commit: 4025f9dff6412d79d4780b7d391f0b5c72d0854e
▶️ Tests: 122368 executed
⚪️ Checks: 32/32 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org