You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2023/08/26 15:16:08 UTC
[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #7282: Update ObjectStore 0.7.0 and Arrow 46.0.0
Dandandan commented on code in PR #7282:
URL: https://github.com/apache/arrow-datafusion/pull/7282#discussion_r1306470653
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -851,19 +851,8 @@ fn eq_dyn_null(
null_equals_null: bool,
) -> Result<BooleanArray, ArrowError> {
match (left.data_type(), right.data_type()) {
- (DataType::Null, DataType::Null) => Ok(BooleanArray::new(
- BooleanBuffer::collect_bool(left.len(), |_| null_equals_null),
- None,
- )),
- _ if null_equals_null => {
- let eq: BooleanArray = eq_dyn(left, right)?;
-
- let left_is_null = is_null(left)?;
- let right_is_null = is_null(right)?;
-
- or_kleene(&and(&left_is_null, &right_is_null)?, &eq)
- }
- _ => eq_dyn(left, right),
+ _ if null_equals_null => not_distinct(&left, &right),
Review Comment:
Nice 👍
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -851,19 +851,8 @@ fn eq_dyn_null(
null_equals_null: bool,
) -> Result<BooleanArray, ArrowError> {
match (left.data_type(), right.data_type()) {
- (DataType::Null, DataType::Null) => Ok(BooleanArray::new(
- BooleanBuffer::collect_bool(left.len(), |_| null_equals_null),
- None,
- )),
- _ if null_equals_null => {
- let eq: BooleanArray = eq_dyn(left, right)?;
-
- let left_is_null = is_null(left)?;
- let right_is_null = is_null(right)?;
-
- or_kleene(&and(&left_is_null, &right_is_null)?, &eq)
- }
- _ => eq_dyn(left, right),
+ _ if null_equals_null => not_distinct(&left, &right),
Review Comment:
Nice 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org