[Impala-ASF-CR] IMPALA-14872: Perform work outside DoFuncForAllEntries

["Michael Smith (Code Review)" <ge...@cloudera.org>]

Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24162 )

Change subject: IMPALA-14872: Perform work outside DoFuncForAllEntries
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc@3066
PS1, Line 3066: DoFuncForAllEntries
> I'll look at them. All of these are tricky: we need to be careful about mem
I want to look more into the patterns around DoFuncForAllEntries before merging this change. IMPALA-14271 addressed network activity while holding a lock, which was the worst impact of this. It'd be nice to avoid doing more work while holding a lock, but not significantly worse in this case than other uses of DoFuncForAllEntries.



-- 
To view, visit http://gerrit.cloudera.org:8080/24162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49f92bf4fe1b773ee8643422091b7252ddd81685
Gerrit-Change-Number: 24162
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 May 2026 17:44:34 +0000
Gerrit-HasComments: Yes