You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/10/22 05:59:25 UTC
[GitHub] incubator-zeppelin pull request: Replace button to div in scatter ...
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/358
Replace button to div in scatter settings
This PR fixes same issue as [ZEPPELIN-351](https://issues.apache.org/jira/browse/ZEPPELIN-351?jql=project%20%3D%20ZEPPELIN) which Firefox/IE users cannot remove fields from pivot settings for scatter chart.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin fix/removeFieldsFromScatterSetting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/358.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #358
----
commit 3a6e58f097924609f82fb77b5d5f7ec220640b96
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-10-22T03:55:40Z
Replace button to div in scatter settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Replace button to div in scatter ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/358
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Replace button to div in scatter ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/358#issuecomment-150112655
Tested with Firefox, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Replace button to div in scatter ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/358#issuecomment-150113094
Good To go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---