You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/31 00:02:01 UTC
[GitHub] [superset] benjreinhart opened a new pull request #13878: fix(#13378): Ensure g.user is set for impersonation
benjreinhart opened a new pull request #13878:
URL: https://github.com/apache/superset/pull/13878
### SUMMARY
This fixes #13378 by ensuring that Flask's global object `g` contains a `user` object set to the user who initiated the request when queries are executing asynchronously. There is currently some deeply buried code that expects this when constructing the query. This is not a particularly robust fix, so if anyone has any suggestions I'd be very interested in hearing them. Ideally, we'd have a way to explicitly pass the username to where it's needed for impersonation configuration (like SQL lab does), but this would require a substantial amount of changes as far as I can tell. Even if refactoring that is the goal, I think we should get this out to unblock folks first.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
This is difficult to test well, so the unit tests were updated to ensure a function is called that I manually tested. This is not a great test, and I almost omitted it altogether, but ended up including it. Let me know if you have suggestions.
Additionally, I would like to test this end-to-end but I don't have that environment setup yet. I'm going to work to get this set up. In the meantime, @juneauwang and @gorcurek if you're able to pull this branch down and test it, that would be lovely.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810820727
# [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=h1) Report
> Merging [#13878](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=desc) (7ed6588) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.00%`.
> The diff coverage is `68.31%`.
> :exclamation: Current head 7ed6588 differs from pull request most recent head 01e226f. Consider uploading reports for the commit 01e226f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13878 +/- ##
==========================================
- Coverage 77.33% 77.32% -0.01%
==========================================
Files 935 935
Lines 47278 47307 +29
Branches 5883 5907 +24
==========================================
+ Hits 36564 36582 +18
- Misses 10570 10581 +11
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <49.09%> (-0.05%)` | :arrow_down: |
| mysql | `80.59% <70.58%> (-0.01%)` | :arrow_down: |
| postgres | `80.50% <66.66%> (-0.14%)` | :arrow_down: |
| python | `80.58% <66.66%> (-0.14%)` | :arrow_down: |
| sqlite | `80.19% <70.58%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=footer). Last update [84560e8...01e226f](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810820727
# [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=h1) Report
> Merging [#13878](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=desc) (7ed6588) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.14%`.
> The diff coverage is `68.31%`.
> :exclamation: Current head 7ed6588 differs from pull request most recent head 01e226f. Consider uploading reports for the commit 01e226f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13878 +/- ##
==========================================
+ Coverage 77.33% 77.48% +0.14%
==========================================
Files 935 935
Lines 47278 47307 +29
Branches 5883 5907 +24
==========================================
+ Hits 36564 36656 +92
+ Misses 10570 10507 -63
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <49.09%> (-0.05%)` | :arrow_down: |
| hive | `80.29% <70.58%> (?)` | |
| mysql | `80.59% <70.58%> (-0.01%)` | :arrow_down: |
| postgres | `80.50% <66.66%> (-0.14%)` | :arrow_down: |
| python | `80.87% <66.66%> (+0.15%)` | :arrow_up: |
| sqlite | `80.19% <70.58%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=footer). Last update [84560e8...01e226f](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810820727
# [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=h1) Report
> Merging [#13878](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=desc) (7ed6588) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.06%`.
> The diff coverage is `68.31%`.
> :exclamation: Current head 7ed6588 differs from pull request most recent head 01e226f. Consider uploading reports for the commit 01e226f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13878 +/- ##
==========================================
- Coverage 77.33% 77.27% -0.07%
==========================================
Files 935 935
Lines 47278 47279 +1
Branches 5883 5907 +24
==========================================
- Hits 36564 36534 -30
- Misses 10570 10601 +31
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <49.09%> (-0.05%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `80.61% <70.58%> (-0.03%)` | :arrow_down: |
| python | `80.61% <70.58%> (-0.11%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| ... and [46 more](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=footer). Last update [84560e8...01e226f](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810820727
# [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=h1) Report
> Merging [#13878](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=desc) (7ed6588) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.15%`.
> The diff coverage is `71.84%`.
> :exclamation: Current head 7ed6588 differs from pull request most recent head 01e226f. Consider uploading reports for the commit 01e226f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13878 +/- ##
==========================================
+ Coverage 77.33% 77.48% +0.15%
==========================================
Files 935 935
Lines 47278 47301 +23
Branches 5883 5907 +24
==========================================
+ Hits 36564 36653 +89
+ Misses 10570 10504 -66
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <49.09%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=footer). Last update [84560e8...01e226f](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810820727
# [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=h1) Report
> Merging [#13878](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=desc) (7ed6588) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.05%`.
> The diff coverage is `68.31%`.
> :exclamation: Current head 7ed6588 differs from pull request most recent head 01e226f. Consider uploading reports for the commit 01e226f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13878 +/- ##
==========================================
- Coverage 77.33% 77.28% -0.06%
==========================================
Files 935 935
Lines 47278 47307 +29
Branches 5883 5907 +24
==========================================
- Hits 36564 36561 -3
- Misses 10570 10602 +32
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <49.09%> (-0.05%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `80.50% <66.66%> (-0.14%)` | :arrow_down: |
| python | `80.50% <66.66%> (-0.22%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| ... and [39 more](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=footer). Last update [84560e8...01e226f](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810820727
# [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=h1) Report
> Merging [#13878](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=desc) (7ed6588) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **increase** coverage by `0.21%`.
> The diff coverage is `68.31%`.
> :exclamation: Current head 7ed6588 differs from pull request most recent head 01e226f. Consider uploading reports for the commit 01e226f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13878 +/- ##
==========================================
+ Coverage 77.33% 77.55% +0.21%
==========================================
Files 935 935
Lines 47278 47307 +29
Branches 5883 5907 +24
==========================================
+ Hits 36564 36690 +126
+ Misses 10570 10473 -97
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <49.09%> (-0.05%)` | :arrow_down: |
| hive | `80.29% <70.58%> (?)` | |
| mysql | `80.59% <70.58%> (-0.01%)` | :arrow_down: |
| postgres | `80.50% <66.66%> (-0.14%)` | :arrow_down: |
| presto | `80.29% <70.58%> (?)` | |
| python | `81.00% <66.66%> (+0.28%)` | :arrow_up: |
| sqlite | `80.19% <70.58%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=footer). Last update [84560e8...01e226f](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] juneauwang edited a comment on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
juneauwang edited a comment on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810927462
Hi @benjreinhart , thanks a lot for your fix! I just tested it on our dev. effective user can be fetched correctly now.
```
effective username is wei-peng.wang
[2021-03-31 09:36:41,850: INFO/ForkPoolWorker-7] effective username is wei-peng.wang
[2021-03-31 09:36:41,851: WARNING/ForkPoolWorker-7] /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt
[2021-03-31 09:36:41,871: WARNING/ForkPoolWorker-7] XXXXIIIIIIIIIIIIII
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio merged pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
robdiciuccio merged pull request #13878:
URL: https://github.com/apache/superset/pull/13878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810820727
# [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=h1) Report
> Merging [#13878](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=desc) (7ed6588) into [master](https://codecov.io/gh/apache/superset/commit/84560e8527a45a7b4ac8d0aa4657a36f9bac7e0b?el=desc) (84560e8) will **decrease** coverage by `0.03%`.
> The diff coverage is `68.31%`.
> :exclamation: Current head 7ed6588 differs from pull request most recent head 01e226f. Consider uploading reports for the commit 01e226f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13878 +/- ##
==========================================
- Coverage 77.33% 77.30% -0.04%
==========================================
Files 935 935
Lines 47278 47307 +29
Branches 5883 5907 +24
==========================================
+ Hits 36564 36572 +8
- Misses 10570 10591 +21
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <49.09%> (-0.05%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `80.50% <66.66%> (-0.14%)` | :arrow_down: |
| python | `80.54% <66.66%> (-0.18%)` | :arrow_down: |
| sqlite | `80.19% <70.58%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | `57.40% <ø> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/13878/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=footer). Last update [84560e8...01e226f](https://codecov.io/gh/apache/superset/pull/13878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] juneauwang commented on pull request #13878: fix(#13378): Ensure g.user is set for impersonation
Posted by GitBox <gi...@apache.org>.
juneauwang commented on pull request #13878:
URL: https://github.com/apache/superset/pull/13878#issuecomment-810927462
Hi @benjreinhart , thanks a lot for your fix! I just tested it on our dev. effective user can be fetched correctly now.
```
effective username is wei-peng.wang
[2021-03-31 09:36:41,850: INFO/ForkPoolWorker-7] effective username is wei-peng.wang
[2021-03-31 09:36:41,851: WARNING/ForkPoolWorker-7] /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt
[2021-03-31 09:36:41,871: WARNING/ForkPoolWorker-7] XXXXIIIIIIIIIIIIII
[2021-03-31 09:36:41,871: WARNING/ForkPoolWorker-7] K2s2l72RGb6h#vuH)-
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org