[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #25511: Add action doc

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on code in PR #25511:
URL: https://github.com/apache/shardingsphere/pull/25511#discussion_r1187040497


##########
docs/community/content/involved/conduct/code.en.md:
##########
@@ -108,3 +108,14 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
    - If a rule's branch is over than `5`, every branch take a new line.
    - Rule name of parser should same with java variable's camel case.
    - Define separate files for every SQL type, file name should consist of `database` + `SQL type` + `Statement`. For example: `MySQLDQLStatement.g4`.
+
+## GitHub Action 规范
+
+- Workflow file name must end with `.yml`
+- Workflow file name must consist with the lowercase of `trigger type-action type`, for example: `nightly-check.yml`. omit trigger type for pull_request, for example: `check.yml`
+- Execution action includes: check, ci, e2e, build

Review Comment:
   Action type or Execution action?



##########
docs/community/content/involved/conduct/code.en.md:
##########
@@ -108,3 +108,14 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
    - If a rule's branch is over than `5`, every branch take a new line.
    - Rule name of parser should same with java variable's camel case.
    - Define separate files for every SQL type, file name should consist of `database` + `SQL type` + `Statement`. For example: `MySQLDQLStatement.g4`.
+
+## GitHub Action 规范
+
+- Workflow file name must end with `.yml`
+- Workflow file name must consist with the lowercase of `trigger type-action type`, for example: `nightly-check.yml`. omit trigger type for pull_request, for example: `check.yml`

Review Comment:
   It is better to rewrite `trigger type-action type` to `triggerType-actionType`



##########
docs/community/content/involved/conduct/code.en.md:
##########
@@ -108,3 +108,14 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
    - If a rule's branch is over than `5`, every branch take a new line.
    - Rule name of parser should same with java variable's camel case.
    - Define separate files for every SQL type, file name should consist of `database` + `SQL type` + `Statement`. For example: `MySQLDQLStatement.g4`.
+
+## GitHub Action 规范

Review Comment:
   All English conducts are end with `.`, please do same thing on `GitHub Action Conduct` as well.



##########
docs/community/content/involved/conduct/code.en.md:
##########
@@ -108,3 +108,14 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
    - If a rule's branch is over than `5`, every branch take a new line.
    - Rule name of parser should same with java variable's camel case.
    - Define separate files for every SQL type, file name should consist of `database` + `SQL type` + `Statement`. For example: `MySQLDQLStatement.g4`.
+
+## GitHub Action 规范

Review Comment:
   Translate?



##########
docs/community/content/involved/conduct/code.en.md:
##########
@@ -108,3 +108,14 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
    - If a rule's branch is over than `5`, every branch take a new line.
    - Rule name of parser should same with java variable's camel case.
    - Define separate files for every SQL type, file name should consist of `database` + `SQL type` + `Statement`. For example: `MySQLDQLStatement.g4`.
+
+## GitHub Action 规范
+
+- Workflow file name must end with `.yml`
+- Workflow file name must consist with the lowercase of `trigger type-action type`, for example: `nightly-check.yml`. omit trigger type for pull_request, for example: `check.yml`
+- Execution action includes: check, ci, e2e, build
+- Trigger type includes: pull_request (without prefix), nightly

Review Comment:
   Trigger type should be the 1st line, Action type 2nd, just keep same sequence with name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org