[GitHub] [pinot] 61yao commented on a diff in pull request #9441: [enhancement] [release-note] Update get bytes to return raw bytes of string and support getBytesMV

[GitBox <gi...@apache.org>]

61yao commented on code in PR #9441:
URL: https://github.com/apache/pinot/pull/9441#discussion_r977084177


##########
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java:
##########
@@ -611,12 +623,8 @@ void readBytesValues(int[] docIds, int length, byte[][] valueBuffer) {
         _dictionary.readBytesValues(dictIdBuffer, length, valueBuffer);
       } else {
         switch (_storedType) {
-          case STRING:
-            for (int i = 0; i < length; i++) {
-              valueBuffer[i] = BytesUtils.toBytes(_reader.getString(docIds[i], readerContext));
-            }
-            break;
           case BYTES:
+          case STRING:

Review Comment:
   I thought we don't want to support this for other types? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org