You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "davidrabinowitz (via GitHub)" <gi...@apache.org> on 2024/07/10 21:31:48 UTC
[PR] Updating google-cloud-dataproc to version 5.10.1 and above [airflow]
davidrabinowitz opened a new pull request, #40707:
URL: https://github.com/apache/airflow/pull/40707
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
The update is to support the new Dataproc Serverless auto-tuning parameters added in version 5.10.1, added in https://github.com/googleapis/google-cloud-python/pull/12823
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating google-cloud-dataproc to version 5.10.1 and above [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #40707:
URL: https://github.com/apache/airflow/pull/40707#discussion_r1674520151
##########
airflow/providers/google/provider.yaml:
##########
@@ -130,7 +130,7 @@ dependencies:
- google-cloud-dataflow-client>=0.8.6
- google-cloud-dataform>=0.5.0
- google-cloud-dataplex>=1.10.0
- - google-cloud-dataproc>=5.8.0
+ - google-cloud-dataproc>=5.10.1
Review Comment:
I am not sure if you understand @davidrabinowitz . There is nothing preventing your users from installing 5.10.1 now., in fact this is a default. Why do you want to forbid others to install previous version? What problem are you trying to solve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating google-cloud-dataproc to version 5.10.1 and above [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #40707:
URL: https://github.com/apache/airflow/pull/40707#issuecomment-2221540171
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating google-cloud-dataproc to version 5.10.1 and above [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #40707:
URL: https://github.com/apache/airflow/pull/40707#discussion_r1673116729
##########
airflow/providers/google/provider.yaml:
##########
@@ -130,7 +130,7 @@ dependencies:
- google-cloud-dataflow-client>=0.8.6
- google-cloud-dataform>=0.5.0
- google-cloud-dataplex>=1.10.0
- - google-cloud-dataproc>=5.8.0
+ - google-cloud-dataproc>=5.10.1
Review Comment:
Why ?
Users can use 5.10 if they wish in fact our constraints pick the most recent possible verison.
Why should we block older versions? 5.8 is not that old
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating google-cloud-dataproc to version 5.10.1 and above [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #40707:
URL: https://github.com/apache/airflow/pull/40707#discussion_r1673116729
##########
airflow/providers/google/provider.yaml:
##########
@@ -130,7 +130,7 @@ dependencies:
- google-cloud-dataflow-client>=0.8.6
- google-cloud-dataform>=0.5.0
- google-cloud-dataplex>=1.10.0
- - google-cloud-dataproc>=5.8.0
+ - google-cloud-dataproc>=5.10.1
Review Comment:
Why ?
Users can use 5.10 if they wish.
Why should we block older versions? 5.8 is not that old
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating google-cloud-dataproc to version 5.10.1 and above [airflow]
Posted by "davidrabinowitz (via GitHub)" <gi...@apache.org>.
davidrabinowitz commented on code in PR #40707:
URL: https://github.com/apache/airflow/pull/40707#discussion_r1674411744
##########
airflow/providers/google/provider.yaml:
##########
@@ -130,7 +130,7 @@ dependencies:
- google-cloud-dataflow-client>=0.8.6
- google-cloud-dataform>=0.5.0
- google-cloud-dataplex>=1.10.0
- - google-cloud-dataproc>=5.8.0
+ - google-cloud-dataproc>=5.10.1
Review Comment:
Google Cloud Dataproc has added [](https://cloud.google.com/dataproc-serverless/docs/concepts/autotuning) and the API support for it is in version 5.10.1. We want our users to be able to set the cohort and scenarios on an out of the box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating google-cloud-dataproc to version 5.10.1 and above [airflow]
Posted by "davidrabinowitz (via GitHub)" <gi...@apache.org>.
davidrabinowitz closed pull request #40707: Updating google-cloud-dataproc to version 5.10.1 and above
URL: https://github.com/apache/airflow/pull/40707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating google-cloud-dataproc to version 5.10.1 and above [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #40707:
URL: https://github.com/apache/airflow/pull/40707#discussion_r1673872826
##########
airflow/providers/google/provider.yaml:
##########
@@ -130,7 +130,7 @@ dependencies:
- google-cloud-dataflow-client>=0.8.6
- google-cloud-dataform>=0.5.0
- google-cloud-dataplex>=1.10.0
- - google-cloud-dataproc>=5.8.0
+ - google-cloud-dataproc>=5.10.1
Review Comment:
Yeah. Quite agree with Elad here. It might cause some conflicts if we are updating the minimum requirements "too aggressively".
Current constraints already point out to 5.10.1 https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt#L341 and when people will be installing provider "with constraints" they will get it (they will also get it when installing provider without constraints). We have the "lowest dependencies" check running that currently verifies if we are not using - in our providers, some features that are not available in the "lowest bound" dependency versions - and we will bump minimum version when it finds that it should be bumped. There is no particular reason I think we should bump it manually here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org