You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2019/07/01 14:26:03 UTC
[configuration] review for PR 30
Hi All:
May anyone that knows enough of the internals of [configuration] please
comment on https://github.com/apache/commons-configuration/pull/30
?
Gary
Re: [configuration] review for PR 30
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 02/07/2019 à 01:59, Gary Gregory a écrit :
> What would you call the method?
I don't know, setPropertyDirectInternal? It's private anyway, the name
isn't important.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [configuration] review for PR 30
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jul 1, 2019 at 6:46 PM Emmanuel Bourg <eb...@apache.org> wrote:
> Le 01/07/2019 à 16:26, Gary Gregory a écrit :
>
> > May anyone that knows enough of the internals of [configuration] please
> > comment on https://github.com/apache/commons-configuration/pull/30
>
> I got a quick look, besides the setArrayProperty method that doesn't
> seem to have the right name (there is nothing specific to arrays in the
> implementation, it just sets the value as is) the PR looks good.
>
What would you call the method?
Gary
>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [configuration] review for PR 30
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 01/07/2019 à 16:26, Gary Gregory a écrit :
> May anyone that knows enough of the internals of [configuration] please
> comment on https://github.com/apache/commons-configuration/pull/30
I got a quick look, besides the setArrayProperty method that doesn't
seem to have the right name (there is nothing specific to arrays in the
implementation, it just sets the value as is) the PR looks good.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org