You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by mbektchiev <gi...@git.apache.org> on 2016/08/26 15:45:48 UTC
[GitHub] cordova-lib pull request #485: CB-11771 Deep symlink directories to target p...
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/485
CB-11771 Deep symlink directories to target project instead of linking the directory itself
When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.
fixes [CB-11771 Installing plugin with symlink option pollutes original directory with intermediate files](https://issues.apache.org/jira/browse/CB-11771)
related to https://github.com/apache/cordova-ios/pull/244 and https://github.com/apache/cordova-android/pull/326
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-lib bektchiev/deep-symlink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/485.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #485
----
commit 1eb9b207718f00d0101d31c44f9a492f5c16725b
Author: Martin Bektchiev <ma...@telerik.com>
Date: 2016-08-26T12:08:16Z
CB-11771 Deep symlink directories to target project instead of linking the directory itself
When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #485: CB-11771 Deep symlink directories to target project ...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/485
I confirmed the leaking! Your patch solves the problem. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #485: CB-11771 Deep symlink directories to target project ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/485
## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/485?src=pr) is 80.81% (diff: 88.88%)
> Merging [#485](https://codecov.io/gh/apache/cordova-lib/pull/485?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will increase coverage by **0.02%**
```diff
@@ master #485 diff @@
==========================================
Files 68 68
Lines 5407 5415 +8
Methods 857 859 +2
Messages 0 0
Branches 1048 1050 +2
==========================================
+ Hits 4368 4376 +8
Misses 1039 1039
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [3b38b53...1eb9b20](https://codecov.io/gh/apache/cordova-lib/compare/3b38b5382b9a52d1fe522514b61d3ebd6016796d...1eb9b207718f00d0101d31c44f9a492f5c16725b?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #485: CB-11771 Deep symlink directories to target project ...
Posted by mbektchiev <gi...@git.apache.org>.
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-lib/pull/485
Can someone please review this PR? https://github.com/apache/cordova-ios/pull/244 is already merged and in order to fix the issue we need this one and https://github.com/apache/cordova-android/pull/326 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #485: CB-11771 Deep symlink directories to target p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/485
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org