You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "cryptoe (via GitHub)" <gi...@apache.org> on 2025/06/23 10:15:07 UTC
[PR] Fix Jakarta upgrade silently ignoring modules registered with the same name (druid)
cryptoe opened a new pull request, #18167:
URL: https://github.com/apache/druid/pull/18167
Bumping Jakarta version to 2.18.4 as part of https://github.com/apache/druid/pull/18013/ seems to fix IGNORE_DUPLICATE_MODULE_REGISTRATIONS. Disabling this feature in case multiple modules are registered with the same name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Jakarta upgrade silently ignoring modules registered with the same name (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #18167:
URL: https://github.com/apache/druid/pull/18167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Jakarta upgrade silently ignoring modules registered with the same name (druid)
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #18167:
URL: https://github.com/apache/druid/pull/18167#discussion_r2161286000
##########
processing/src/main/java/org/apache/druid/jackson/DefaultObjectMapper.java:
##########
@@ -85,6 +85,10 @@
// closed after an exception is thrown while writing.
configure(JsonGenerator.Feature.AUTO_CLOSE_JSON_CONTENT, false);
+ // Bumping Jakarta version to 2.18.4 as part of https://github.com/apache/druid/pull/18013/ seems to fix IGNORE_DUPLICATE_MODULE_REGISTRATIONS.
+ // Disabling this feature in case multiple modules are registered with the same name.
+ configure(MapperFeature.IGNORE_DUPLICATE_MODULE_REGISTRATIONS, false);
Review Comment:
## Deprecated method or constructor invocation
Invoking [ObjectMapper.configure](1) should be avoided because it has been deprecated.
[Show more details](https://github.com/apache/druid/security/code-scanning/9257)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org