You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/01/21 17:24:20 UTC
[kudu-CR] [master] Replace hive metastore sasl enabled validator
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15076
Change subject: [master] Replace hive_metastore_sasl_enabled validator
......................................................................
[master] Replace hive_metastore_sasl_enabled validator
The hive_metastore_sasl_enabled GROUP_FLAG_VALIDATOR
that was added in a76177f was accidentally removed in 4f82a46.
The validation is added back in this patch. However, it is
validated in RunMasterServer() as opposed to using a
GROUP_FLAG_VALIDATOR because the master server can be run
from the tools now.
Change-Id: I9ecea5b4b4e0d4bdd198241f23bf34ea46ff6945
---
M src/kudu/master/master_runner.cc
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/15076/1
--
To view, visit http://gerrit.cloudera.org:8080/15076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ecea5b4b4e0d4bdd198241f23bf34ea46ff6945
Gerrit-Change-Number: 15076
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [master] Replace hive metastore sasl enabled validator
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15076 )
Change subject: [master] Replace hive_metastore_sasl_enabled validator
......................................................................
[master] Replace hive_metastore_sasl_enabled validator
The hive_metastore_sasl_enabled GROUP_FLAG_VALIDATOR
that was added in a76177f was accidentally removed in 4f82a46.
The validation is added back in this patch. However, it is
validated in RunMasterServer() as opposed to using a
GROUP_FLAG_VALIDATOR because the master server can be run
from the tools now.
Change-Id: I9ecea5b4b4e0d4bdd198241f23bf34ea46ff6945
Reviewed-on: http://gerrit.cloudera.org:8080/15076
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/master/master_runner.cc
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ecea5b4b4e0d4bdd198241f23bf34ea46ff6945
Gerrit-Change-Number: 15076
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master] Replace hive metastore sasl enabled validator
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15076 )
Change subject: [master] Replace hive_metastore_sasl_enabled validator
......................................................................
Patch Set 1: Code-Review+2
Thanks for catching this!
--
To view, visit http://gerrit.cloudera.org:8080/15076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ecea5b4b4e0d4bdd198241f23bf34ea46ff6945
Gerrit-Change-Number: 15076
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 Jan 2020 18:05:46 +0000
Gerrit-HasComments: No