[jira] [Commented] (SOLR-12690) Regularize LoggerFactory declarations

["Christine Poerschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587935#comment-16587935 ] 

Christine Poerschke commented on SOLR-12690:
--------------------------------------------

bq. ... I think there's another Jira about this that I can't find just now, ring any bell? ...

I've linked SOLR-12419 and SOLR-12557 for {{solr/contrib}} and {{solr/core}} directories. {{solr/solrj}} is yet to be done (no ticket yet as far as i know) and {{lucene}} is not-applicable (probably).

bq. ... Once that's done, is there a good way to make violations of this fail precommit?

Via {{lucene/tools/src/groovy/check-source-patterns.groovy}} could be one way, there could be other ways too though.

> Regularize LoggerFactory declarations
> -------------------------------------
>
>                 Key: SOLR-12690
>                 URL: https://issues.apache.org/jira/browse/SOLR-12690
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>
> LoggerFactory declarations have several different forms, they should all be:
> private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
>  * lowercase log
>  * private static
>  * non hard-coded class lookup.
> I'm going to regularize all of these, I think there are about 80 currently, we've been nibbling away at this but I'll try to do it in one go.
> [~cpoerschke] I think there's another Jira about this that I can't find just now, ring any bells?
> Once that's done, is there a good way to make violations of this fail precommit?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org