[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1170: [#1164] refactor: Exposing the getDataLen method for ShuffleDataResult

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on code in PR #1170:
URL: https://github.com/apache/incubator-uniffle/pull/1170#discussion_r1305085360


##########
common/src/main/java/org/apache/uniffle/common/ShuffleDataResult.java:
##########
@@ -71,6 +71,10 @@ public byte[] getData() {
     return ByteBufUtils.readBytes(buffer.byteBuf());
   }
 
+  public int getDataLength() {
+    return getData().length;

Review Comment:
   If we use off memory, we use the method `getData`, we will copy extra memory copy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org