[GitHub] [maven-plugin-tools] timtebeek commented on a diff in pull request #227: [MNG-7416] Simplify Boolean expressions and returns

["timtebeek (via GitHub)" <gi...@apache.org>]

timtebeek commented on code in PR #227:
URL: https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337254040


##########
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##########
@@ -510,7 +510,7 @@ private Map<String, JavaField> extractFieldParameterTags(JavaClass javaClass) {
         if (superClass != null) {
             rawParams = extractFieldParameterTags(superClass);
         } else {
-            rawParams = new TreeMap<String, JavaField>();
+            rawParams = new TreeMap<>();

Review Comment:
   Hmm, yes I guess that's true; would you want me to revert it here? Or keep it since the variable is still mostly in view?
   
   Alternatively we can pull down the variable declaration to just above the if statement, as that would also clear up any ambiguity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org