[GitHub] [geode] DonalEvans commented on a change in pull request #7487: GEODE-10162: Try to find and set version tag if needed

[GitBox <gi...@apache.org>]

DonalEvans commented on a change in pull request #7487:
URL: https://github.com/apache/geode/pull/7487#discussion_r837997466



##########
File path: geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRegionTest.java
##########
@@ -260,4 +266,132 @@ public void validateAsynchronousEventDispatcherShouldThrowExceptionWhenDispatche
         .hasMessage("Parallel Gateway Sender " + senderId
             + " can not be used with replicated region " + regionPath);
   }
+
+  @Test
+  public void hasSeenEventDoseNotFindAndSetVersionTagIfFoundInEventTrackerAndVersionTagIsSet() {

Review comment:
       Typo here and in other tests added, should be "DoesNot" rather than "DoseNot"

##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
##########
@@ -526,21 +526,36 @@ public boolean hasSeenEvent(EntryEventImpl event) {
     isDuplicate = getEventTracker().hasSeenEvent(event);
     if (isDuplicate) {
       markEventAsDuplicate(event);
+      if (event.getVersionTag() == null && event.getRegion().getConcurrencyChecksEnabled()
+          && event.getEventId() != null) {
+        // For a retry, versionTag can be missing possibly due to no versionTag recorded during gii.
+        findAndSetVersionTag(event);
+        if (event.getVersionTag() == null) {
+          logger.info("No version tag can be found in cluster when retrying the following event {}",
+              event);

Review comment:
       Is this likely to be logged often? If there are situations where it could be logged a lot, it might be better to make this debug level.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org