You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2025/08/18 17:51:14 UTC
[PR] fix: sitemesh3 rendering [grails-core]
jdaugherty opened a new pull request, #14989:
URL: https://github.com/apache/grails-core/pull/14989
When we were forced to rename sitemesh -> grailsLayout due to the license audit of sitemesh2, it broke sitemesh 3. The tags are being generated still as `grailsLayout:` in the GrailsLayoutPreprocessor so sitemesh3's SitemeshTagLib needs to use the same namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: sitemesh3 rendering [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #14989:
URL: https://github.com/apache/grails-core/pull/14989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: sitemesh3 rendering [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14989:
URL: https://github.com/apache/grails-core/pull/14989#issuecomment-3197941689
I'm epxecting all tests to pass now; here's the local build scan: https://ge.grails.org/s/ogwckaqwujlks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: sitemesh3 rendering [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14989:
URL: https://github.com/apache/grails-core/pull/14989#issuecomment-3201227273
> Nice James!
>
> What is the purpose of the `<body onload="test();">` function call in some of the `endToEnd` views?
Sitemesh parses the html and I think this was meant as the ultimate test to make sure it was handling complicated attributes correctly. I didn't write these tests - they are from the original Sitemesh 2 test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org