You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "every-breaking-wave (via GitHub)" <gi...@apache.org> on 2023/03/11 05:45:10 UTC
[GitHub] [incubator-celeborn] every-breaking-wave opened a new pull request, #1327: Update prometheus-podmonitor.yaml
every-breaking-wave opened a new pull request, #1327:
URL: https://github.com/apache/incubator-celeborn/pull/1327
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Change the matchLabels of podMonitor from` app.kubernetes.io/name` to `app.kubernetes.io/role`
### Why are the changes needed?
when deploy celeborn on k8s, master pods will be labeled as
This does not match` app.kubernetes.io/name: celeborn-master` in `prometheus-podmonitor.yaml`, in fact, this label is a combination of `name `and `role`, after changing it to `app.kubernetes.io/role` to match The metrics of the pod can be captured normally.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1327: [CELEBORN-401] Modify prometheus-podmonitor.yaml to collect metrics correctly
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1327:
URL: https://github.com/apache/incubator-celeborn/pull/1327#issuecomment-1464902811
I created a [jira](https://issues.apache.org/jira/browse/CELEBORN-401) and modified the title. We prefer that each commit links to a jira :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] every-breaking-wave commented on pull request #1327: [CELEBORN-401] Modify prometheus-podmonitor.yaml to collect metrics correctly
Posted by "every-breaking-wave (via GitHub)" <gi...@apache.org>.
every-breaking-wave commented on PR #1327:
URL: https://github.com/apache/incubator-celeborn/pull/1327#issuecomment-1464911709
> I created a [jira](https://issues.apache.org/jira/browse/CELEBORN-401) and modified the title. We prefer that each commit links to a jira :)
got it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1327: Update prometheus-podmonitor.yaml
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1327:
URL: https://github.com/apache/incubator-celeborn/pull/1327#issuecomment-1464842051
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1327?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1327](https://codecov.io/gh/apache/incubator-celeborn/pull/1327?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a174ed2) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/a336f12cc86cb1b1f8daa2efa273a515918a2888?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a336f12) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1327 +/- ##
============================================
+ Coverage 27.78% 27.82% +0.04%
- Complexity 841 846 +5
============================================
Files 221 221
Lines 18459 18459
Branches 1979 1979
============================================
+ Hits 5127 5134 +7
+ Misses 12976 12974 -2
+ Partials 356 351 -5
```
[see 2 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1327/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1327: Update prometheus-podmonitor.yaml
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1327:
URL: https://github.com/apache/incubator-celeborn/pull/1327#issuecomment-1464840779
cc @zwangsheng please review this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1327: [CELEBORN-401] Modify prometheus-podmonitor.yaml to collect metrics correctly
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1327:
URL: https://github.com/apache/incubator-celeborn/pull/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on pull request #1327: [CELEBORN-401] Modify prometheus-podmonitor.yaml to collect metrics correctly
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #1327:
URL: https://github.com/apache/incubator-celeborn/pull/1327#issuecomment-1465567229
Sorry for be late, LGTM.
Thanks for you contribution @every-breaking-wave !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org