You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2008/09/19 15:19:45 UTC
Re: svn commit: r33186 - trunk/build/generator/swig
arfrever@tigris.org wrote:
> Author: arfrever
> Date: Fri Sep 19 08:12:48 2008
> New Revision: 33186
>
> Log:
> * build/generator/swig/__init__.py
> (Generator.__init__, Generator.version): Pass a list to _exec.output().
>
> Modified:
> trunk/build/generator/swig/__init__.py
>
> Modified: trunk/build/generator/swig/__init__.py
> URL: http://svn.collab.net/viewvc/svn/trunk/build/generator/swig/__init__.py?pathrev=33186&r1=33185&r2=33186
> ==============================================================================
> --- trunk/build/generator/swig/__init__.py Fri Sep 19 07:44:42 2008 (r33185)
> +++ trunk/build/generator/swig/__init__.py Fri Sep 19 08:12:48 2008 (r33186)
> @@ -32,14 +32,14 @@ class Generator:
> # Calculate SWIG paths
> self.swig_path = swig_path
> try:
> - self.swig_libdir = _exec.output("%s -swiglib" % self.swig_path, strip=1)
> + self.swig_libdir = _exec.output(["%s" % self.swig_path, "-swiglib"], strip=1)
There's no need to do "%s" % self.swig_path, just use self.swig_path.
Also, please check that lines are less then 80 characters long.
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33186 - trunk/build/generator/swig
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-19 17:19:45 Blair Zajac napisał(a):
> arfrever@tigris.org wrote:
> > Author: arfrever
> > Date: Fri Sep 19 08:12:48 2008
> > New Revision: 33186
> >
> > Log:
> > * build/generator/swig/__init__.py
> > (Generator.__init__, Generator.version): Pass a list to _exec.output().
> >
> > Modified:
> > trunk/build/generator/swig/__init__.py
> >
> > Modified: trunk/build/generator/swig/__init__.py
> > URL: http://svn.collab.net/viewvc/svn/trunk/build/generator/swig/__init__.py?pathrev=33186&r1=33185&r2=33186
> > ==============================================================================
> > --- trunk/build/generator/swig/__init__.py Fri Sep 19 07:44:42 2008 (r33185)
> > +++ trunk/build/generator/swig/__init__.py Fri Sep 19 08:12:48 2008 (r33186)
> > @@ -32,14 +32,14 @@ class Generator:
> > # Calculate SWIG paths
> > self.swig_path = swig_path
> > try:
> > - self.swig_libdir = _exec.output("%s -swiglib" % self.swig_path, strip=1)
> > + self.swig_libdir = _exec.output(["%s" % self.swig_path, "-swiglib"], strip=1)
>
> There's no need to do "%s" % self.swig_path, just use self.swig_path.
>
> Also, please check that lines are less then 80 characters long.
Fixed in r33188.
--
Arfrever Frehtes Taifersar Arahesis