[GitHub] stevedlawrence commented on a change in pull request #129: Cross Testing Capability with IBM DFDL

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #129: Cross Testing Capability with IBM DFDL
URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r229032944
 
 

 ##########
 File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
 ##########
 @@ -136,42 +138,43 @@ private[tdml] object DFDLTestSuite {
       case other => Assert.invariantFailed("String '%s' not valid for round trip".format(other))
     }
 
-  type CompileResult = Either[Seq[Diagnostic], (Seq[Diagnostic], DFDL.DataProcessor)]
 }
+
 //
 // TODO: validate the infoset XML (expected result) against the DFDL Schema, that is using it as an XML Schema
 // for the infoset. This would prevent errors where the infoset instance and the schema drift apart under maintenance.
 //
 // TODO: validate the actual result against the DFDL Schema using it as an XML Schema.
 //
 /**
- * TDML test suite runner
- *
- * Keep this independent of Daffodil, so that it can be used to run tests against other DFDL implementations as well.
- * E.g., it should only need an API specified as a collection of Scala traits, and some simple way to inject
- * dependency on one factory to create processors.
- *
- *
- * Use the validateTDMLFile arg to bypass validation of the TDML document itself.
- *
- * This is used for testing whether one can detect validation errors
- * in the DFDL schema.
- *
- * Without this, you can't get to the validation errors, because it
- * rejects the TDML file itself.
- *
- * defaultRoundTripDefault if true the round trip default for the test suite will be
- * taken from this value if it is not specified on the testSuite itself.
- */
-
-class DFDLTestSuite private[tdml] (
+  * TDML test suite runner
+  *
+  * Keep this independent of Daffodil, so that it can be used to run tests against other DFDL implementations as well.
+  * E.g., it should only need an API specified as a collection of Scala traits, and some simple way to inject
+  * dependency on one factory to create processors.
+  *
+  *
+  * Use the validateTDMLFile arg to bypass validation of the TDML document itself.
+  *
+  * This is used for testing whether one can detect validation errors
+  * in the DFDL schema.
+  *
+  * Without this, you can't get to the validation errors, because it
+  * rejects the TDML file itself.
+  *
+  * defaultRoundTripDefault if true the round trip default for the test suite will be
+  * taken from this value if it is not specified on the testSuite itself.
+  */
 
 Review comment:
   Add comment for defaultImplementationsDefault?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services