You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/09 08:18:31 UTC
[GitHub] [arrow] revit13 opened a new pull request #8148: "ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory"
revit13 opened a new pull request #8148:
URL: https://github.com/apache/arrow/pull/8148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8148: "ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory"
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8148:
URL: https://github.com/apache/arrow/pull/8148#issuecomment-689410400
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #8148: "ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory"
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #8148:
URL: https://github.com/apache/arrow/pull/8148#discussion_r485435374
##########
File path: cpp/src/parquet/test_encryption_util.h
##########
@@ -57,6 +57,7 @@ const char kFooterEncryptionKey[] = "0123456789012345"; // 128bit/16
const char kColumnEncryptionKey1[] = "1234567890123450";
const char kColumnEncryptionKey2[] = "1234567890123451";
const char kFileName[] = "tester";
+const char kTempDir[] = "/tmp";
Review comment:
This is not very customary on Windows. Can you use a cross-platform facility? For example, we have a facility to create temporary directories:
https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/io_util.h#L305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8148: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8148:
URL: https://github.com/apache/arrow/pull/8148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8148: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8148:
URL: https://github.com/apache/arrow/pull/8148#issuecomment-689586337
https://issues.apache.org/jira/browse/ARROW-9104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8148: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8148:
URL: https://github.com/apache/arrow/pull/8148#issuecomment-690267262
It appears this was obsoleted by #8159, closing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org