You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/21 21:24:08 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #6732: [CONDA] Revamp conda recipe.
tqchen opened a new pull request #6732:
URL: https://github.com/apache/incubator-tvm/pull/6732
- Combines two packages into a single recipe.
- Enable windows build.
- Better packaging hash tag (use git string).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6732: [CONDA] Revamp conda recipe.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6732:
URL: https://github.com/apache/incubator-tvm/pull/6732#issuecomment-713885953
cc @junrushao1994 @abergeron
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6732: [CONDA] Revamp conda recipe.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6732:
URL: https://github.com/apache/incubator-tvm/pull/6732#issuecomment-714631370
Thanks @junrushao1994 updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6732: [CONDA] Revamp conda recipe.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6732:
URL: https://github.com/apache/incubator-tvm/pull/6732#discussion_r510205933
##########
File path: conda/recipe/meta.yaml
##########
@@ -0,0 +1,88 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% set version = '0.8.dev0' %}
+{% set pkg_name = 'tvm' %}
+{% set cuda_tag = cuda_version | replace('.', '') %} # [cuda]
+{% set pkg_name = pkg_name + '-cu' + cuda_tag %} # [cuda]
+{% set build_tag = environ.get('GIT_BUILD_STR', 'unknown') %}
+{% set build_tag = build_tag + '_h' + PKG_HASH + '_' + PKG_BUILDNUM %}
+
+package:
+ name: {{ pkg_name }}-package
+ version: {{ version }}
+
+source:
+ path: '../..'
+
+build:
+ number: 0
+ include_recipe: False
+ missing_dso_whitelist:
+ - "*libcuda.*" # [linux]
+
+requirements:
+ build:
+ # The anaconda compilers for OS X are old an annoying
+ # so we rely on the platform ones for now
+ - {{ compiler('cxx') }} # [not osx]
+ - cmake
+ - make # [not win]
+ host:
+ - zlib
+ - llvmdev ==10.0.0
+
+outputs:
+ - name: {{ pkg_name }}-libs
+ script: install_libtvm.bat # [win]
+ script: install_libtvm.sh # [not win]
+ string: {{ build_tag }}
+ requirements:
+ build:
+ - {{ compiler('cxx') }}
+ - cmake
+ - git
+ - make # [not win]
+ host:
+ - zlib
+ - llvmdev ==10.0.0
Review comment:
this is conda specific syntax(space will not work)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6732: [CONDA] Revamp conda recipe.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6732:
URL: https://github.com/apache/incubator-tvm/pull/6732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6732: [CONDA] Revamp conda recipe.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6732:
URL: https://github.com/apache/incubator-tvm/pull/6732#discussion_r510187436
##########
File path: docker/Dockerfile.conda_cuda90
##########
@@ -17,30 +17,16 @@
FROM nvidia/cuda:9.0-devel-ubuntu16.04
-RUN apt-get update && apt-get install -y --no-install-recommends \
- bzip2 curl sudo binutils && \
- rm -rf /var/lib/apt/lists/*
+RUN apt-get update --fix-missing && apt-get install -y bzip2 wget sudo binutils git
-RUN curl -fsSL http://developer.download.nvidia.com/compute/redist/cudnn/v7.6.0/cudnn-9.0-linux-x64-v7.6.0.64.tgz -O && \
+RUN wget -q http://developer.download.nvidia.com/compute/redist/cudnn/v7.6.0/cudnn-9.0-linux-x64-v7.6.0.64.tgz && \
tar --no-same-owner -xzf cudnn-9.0-linux-x64-v7.6.0.64.tgz -C /usr/local && \
rm cudnn-9.0-linux-x64-v7.6.0.64.tgz && \
ldconfig
-
-RUN curl -o ~/miniconda.sh -O https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh && \
- chmod +x ~/miniconda.sh && \
- ~/miniconda.sh -b -p /opt/conda && \
- rm ~/miniconda.sh && \
- /opt/conda/bin/conda upgrade --all && \
- /opt/conda/bin/conda install conda-build conda-verify && \
- /opt/conda/bin/conda clean -ya
-
-RUN /opt/conda/bin/conda install --download-only cmake make zlib
-RUN /opt/conda/bin/conda install --download-only -c numba llvmdev=8.0.0
+COPY install/ubuntu_install_conda.sh /install/ubuntu_install_conda.sh
+RUN bash /install/ubuntu_install_conda.sh
ENV PATH /opt/conda/bin:$PATH
ENV LD_LIBRARY_PATH /usr/local/nvidia/lib:/usr/local/nvidia/lib64
-ENV CONDA_BLD_PATH /tmp
-
-WORKDIR /workspace
-RUN chmod -R a+w /workspace
\ No newline at end of file
+ENV CONDA_BLD_PATH /tmp
Review comment:
add EOL
##########
File path: docker/Dockerfile.conda_cuda100
##########
@@ -17,30 +17,16 @@
FROM nvidia/cuda:10.0-devel-ubuntu16.04
-RUN apt-get update && apt-get install -y --no-install-recommends \
- bzip2 curl sudo binutils && \
- rm -rf /var/lib/apt/lists/*
+RUN apt-get update --fix-missing && apt-get install -y bzip2 wget sudo binutils git
-RUN curl -fsSL http://developer.download.nvidia.com/compute/redist/cudnn/v7.6.0/cudnn-10.0-linux-x64-v7.6.0.64.tgz -O && \
+RUN wget -q http://developer.download.nvidia.com/compute/redist/cudnn/v7.6.0/cudnn-10.0-linux-x64-v7.6.0.64.tgz && \
tar --no-same-owner -xzf cudnn-10.0-linux-x64-v7.6.0.64.tgz -C /usr/local && \
rm cudnn-10.0-linux-x64-v7.6.0.64.tgz && \
ldconfig
-
-RUN curl -o ~/miniconda.sh -O https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh && \
- chmod +x ~/miniconda.sh && \
- ~/miniconda.sh -b -p /opt/conda && \
- rm ~/miniconda.sh && \
- /opt/conda/bin/conda upgrade --all && \
- /opt/conda/bin/conda install conda-build conda-verify && \
- /opt/conda/bin/conda clean -ya
-
-RUN /opt/conda/bin/conda install --download-only cmake make zlib
-RUN /opt/conda/bin/conda install --download-only -c numba llvmdev=8.0.0
+COPY install/ubuntu_install_conda.sh /install/ubuntu_install_conda.sh
+RUN bash /install/ubuntu_install_conda.sh
ENV PATH /opt/conda/bin:$PATH
ENV LD_LIBRARY_PATH /usr/local/nvidia/lib:/usr/local/nvidia/lib64
-ENV CONDA_BLD_PATH /tmp
-
-WORKDIR /workspace
-RUN chmod -R a+w /workspace
\ No newline at end of file
+ENV CONDA_BLD_PATH /tmp
Review comment:
add EOL
##########
File path: conda/recipe/meta.yaml
##########
@@ -0,0 +1,88 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% set version = '0.8.dev0' %}
+{% set pkg_name = 'tvm' %}
+{% set cuda_tag = cuda_version | replace('.', '') %} # [cuda]
+{% set pkg_name = pkg_name + '-cu' + cuda_tag %} # [cuda]
+{% set build_tag = environ.get('GIT_BUILD_STR', 'unknown') %}
+{% set build_tag = build_tag + '_h' + PKG_HASH + '_' + PKG_BUILDNUM %}
+
+package:
+ name: {{ pkg_name }}-package
+ version: {{ version }}
+
+source:
+ path: '../..'
+
+build:
+ number: 0
+ include_recipe: False
+ missing_dso_whitelist:
+ - "*libcuda.*" # [linux]
+
+requirements:
+ build:
+ # The anaconda compilers for OS X are old an annoying
+ # so we rely on the platform ones for now
+ - {{ compiler('cxx') }} # [not osx]
+ - cmake
+ - make # [not win]
+ host:
+ - zlib
+ - llvmdev ==10.0.0
+
+outputs:
+ - name: {{ pkg_name }}-libs
+ script: install_libtvm.bat # [win]
+ script: install_libtvm.sh # [not win]
+ string: {{ build_tag }}
+ requirements:
+ build:
+ - {{ compiler('cxx') }}
+ - cmake
+ - git
+ - make # [not win]
+ host:
+ - zlib
+ - llvmdev ==10.0.0
Review comment:
why not
```suggestion
- llvmdev == 10.0.0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6732: [CONDA] Revamp conda recipe.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6732:
URL: https://github.com/apache/incubator-tvm/pull/6732#discussion_r510206982
##########
File path: conda/recipe/meta.yaml
##########
@@ -0,0 +1,88 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% set version = '0.8.dev0' %}
+{% set pkg_name = 'tvm' %}
+{% set cuda_tag = cuda_version | replace('.', '') %} # [cuda]
+{% set pkg_name = pkg_name + '-cu' + cuda_tag %} # [cuda]
+{% set build_tag = environ.get('GIT_BUILD_STR', 'unknown') %}
+{% set build_tag = build_tag + '_h' + PKG_HASH + '_' + PKG_BUILDNUM %}
+
+package:
+ name: {{ pkg_name }}-package
+ version: {{ version }}
+
+source:
+ path: '../..'
+
+build:
+ number: 0
+ include_recipe: False
+ missing_dso_whitelist:
+ - "*libcuda.*" # [linux]
+
+requirements:
+ build:
+ # The anaconda compilers for OS X are old an annoying
+ # so we rely on the platform ones for now
+ - {{ compiler('cxx') }} # [not osx]
+ - cmake
+ - make # [not win]
+ host:
+ - zlib
+ - llvmdev ==10.0.0
+
+outputs:
+ - name: {{ pkg_name }}-libs
+ script: install_libtvm.bat # [win]
+ script: install_libtvm.sh # [not win]
+ string: {{ build_tag }}
+ requirements:
+ build:
+ - {{ compiler('cxx') }}
+ - cmake
+ - git
+ - make # [not win]
+ host:
+ - zlib
+ - llvmdev ==10.0.0
Review comment:
interesting...got it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6732: [CONDA] Revamp conda recipe.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6732:
URL: https://github.com/apache/incubator-tvm/pull/6732#issuecomment-713905783
Nice! I am a big fan of conda! Will take a look tonight!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org