You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "iffyio (via GitHub)" <gi...@apache.org> on 2025/01/23 16:37:12 UTC
[PR] BigQuery: Add support for select expr star [datafusion-sqlparser-rs]
iffyio opened a new pull request, #1680:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1680
Adds support for wildcard expression on arbitrary
expressions in select lists.
Example:
```sql
SELECT l.LOCATION[offset(0)].* FROM l
```
https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#select_expression_star
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] BigQuery: Add support for select expr star [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #1680:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1680#discussion_r1930933187
##########
tests/sqlparser_common.rs:
##########
@@ -1050,6 +1053,84 @@ fn parse_column_aliases() {
one_statement_parses_to("SELECT a.col + 1 newname FROM foo AS a", sql);
}
+#[test]
+fn parse_select_expr_star() {
+ let dialects = all_dialects_where(|d| d.supports_select_expr_star());
+
+ // Identifier wildcard expansion.
+ let select = dialects.verified_only_select("SELECT foo.bar.* FROM T");
+ let SelectItem::QualifiedWildcard(SelectItemQualifiedWildcardKind::ObjectName(object_name), _) =
+ only(&select.projection)
+ else {
+ unreachable!(
+ "expected wildcard select item: got {:?}",
+ &select.projection[0]
+ )
+ };
+ assert_eq!(
+ &ObjectName::from(
+ ["foo", "bar"]
+ .into_iter()
+ .map(Ident::new)
+ .collect::<Vec<_>>()
+ ),
+ object_name
+ );
+
+ // Arbitrary compound expression with wildcard expansion.
+ let select = dialects.verified_only_select("SELECT foo - bar.* FROM T");
Review Comment:
:sweat_smile: thankfully the query isn't semantically valid, maybe the test is misleading in that sense, I added it only to verify that the parser accepts arbitrary expressions and wildcard on variables, but as far as binary operators specifically combined with the wildcard syntax wouldn't have meaning in BigQuery either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] BigQuery: Add support for select expr star [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #1680:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] BigQuery: Add support for select expr star [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #1680:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1680#discussion_r1930896465
##########
tests/sqlparser_common.rs:
##########
@@ -1050,6 +1053,84 @@ fn parse_column_aliases() {
one_statement_parses_to("SELECT a.col + 1 newname FROM foo AS a", sql);
}
+#[test]
+fn parse_select_expr_star() {
+ let dialects = all_dialects_where(|d| d.supports_select_expr_star());
+
+ // Identifier wildcard expansion.
+ let select = dialects.verified_only_select("SELECT foo.bar.* FROM T");
+ let SelectItem::QualifiedWildcard(SelectItemQualifiedWildcardKind::ObjectName(object_name), _) =
+ only(&select.projection)
Review Comment:
`only` is a neat trick
##########
src/ast/query.rs:
##########
@@ -586,6 +586,20 @@ impl fmt::Display for Cte {
}
}
+/// Represents an expression behind a wildcard expansion in a projection.
+/// `SELECT T.* FROM T;
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub enum SelectItemQualifiedWildcardKind {
+ /// Expression is an object name.
+ /// e.g. `alias.*` or even `schema.table.*`
+ ObjectName(ObjectName),
+ /// Select star on an arbitrary expression.
Review Comment:
👍
##########
tests/sqlparser_common.rs:
##########
@@ -1050,6 +1053,84 @@ fn parse_column_aliases() {
one_statement_parses_to("SELECT a.col + 1 newname FROM foo AS a", sql);
}
+#[test]
+fn parse_select_expr_star() {
+ let dialects = all_dialects_where(|d| d.supports_select_expr_star());
+
+ // Identifier wildcard expansion.
+ let select = dialects.verified_only_select("SELECT foo.bar.* FROM T");
+ let SelectItem::QualifiedWildcard(SelectItemQualifiedWildcardKind::ObjectName(object_name), _) =
+ only(&select.projection)
+ else {
+ unreachable!(
+ "expected wildcard select item: got {:?}",
+ &select.projection[0]
+ )
+ };
+ assert_eq!(
+ &ObjectName::from(
+ ["foo", "bar"]
+ .into_iter()
+ .map(Ident::new)
+ .collect::<Vec<_>>()
+ ),
+ object_name
+ );
+
+ // Arbitrary compound expression with wildcard expansion.
+ let select = dialects.verified_only_select("SELECT foo - bar.* FROM T");
Review Comment:
this is kind of wild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org