[GitHub] [pinot] Jackie-Jiang commented on pull request #11591: Throw exception when schema name doesn't match table name

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on PR #11591:
URL: https://github.com/apache/pinot/pull/11591#issuecomment-1718741796

   cc @mcvsubbu @siddharthteotia @yupeng9 @jadami10 
   We already deprecated the schema name from table config for years (since 2019), and suggest using raw table name as schema name for the following reasons:
   - Error prune: sometimes user accidentally copy the table config and point to the wrong schema
   - Easier lookup: we can easily look up the schema for a table without going 2 hops, more importantly, we always know the table associated with the schema. Currently we need to scan all the tables in order to find if a schema can be deleted
   - Easier management: in the future we can consider managing table config and schema together (we already started this by introducing the `TableConfigs` concept
   
   Now we want to start the process of enforcing it. Do you have concern about this?
   After preventing new table with different schema being created, we will provide an one time migration to rename the schema to match the table config.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org