You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/17 04:51:16 UTC
[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request
#4791: Fix 4782
yu199195 opened a new pull request #4791: Fix 4782
URL: https://github.com/apache/incubator-shardingsphere/pull/4791
Fixes
https://github.com/apache/incubator-shardingsphere/issues/4782
another Fix Solve the problem of Chinese file path chaos when loading the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4791: Fix
4782
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4791: Fix 4782
URL: https://github.com/apache/incubator-shardingsphere/pull/4791#issuecomment-599885278
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4791?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3df3a21`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4791?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4791 +/- ##
=========================================
Coverage ? 56.19%
Complexity ? 448
=========================================
Files ? 1163
Lines ? 20899
Branches ? 3880
=========================================
Hits ? 11744
Misses ? 8426
Partials ? 729
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4791?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...shardingsphere/test/sql/loader/SQLCasesLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4791/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3FsLXRlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL2xvYWRlci9TUUxDYXNlc0xvYWRlci5qYXZh) | `70.23% <60%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4791?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4791?src=pr&el=footer). Last update [3df3a21...c175554](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4791?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4791: Fix
4782
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4791: Fix 4782
URL: https://github.com/apache/incubator-shardingsphere/pull/4791#issuecomment-599946122
I just close this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4791: Fix 4782
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4791: Fix 4782
URL: https://github.com/apache/incubator-shardingsphere/pull/4791#issuecomment-599886544
## Pull Request Test Coverage Report for [Build 10306](https://coveralls.io/builds/29411591)
* **3** of **3** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.002%**) to **59.744%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29411591/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29411591) |
| :-- | --: |
| Change from base [Build 1089](https://coveralls.io/builds/29409529): | -0.002% |
| Covered Lines: | 12480 |
| Relevant Lines: | 20889 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #4791: Fix
4782
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #4791: Fix 4782
URL: https://github.com/apache/incubator-shardingsphere/pull/4791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4791: Fix
4782
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4791: Fix 4782
URL: https://github.com/apache/incubator-shardingsphere/pull/4791#issuecomment-599886544
## Pull Request Test Coverage Report for [Build 10296](https://coveralls.io/builds/29409866)
* **3** of **5** **(60.0%)** changed or added relevant lines in **1** file are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.007%**) to **59.74%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-sql-test/src/main/java/org/apache/shardingsphere/test/sql/loader/SQLCasesLoader.java](https://coveralls.io/builds/29409866/source?filename=sharding-sql-test%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Ftest%2Fsql%2Floader%2FSQLCasesLoader.java#L87) | 3 | 5 | 60.0%
<!-- | **Total:** | **3** | **5** | **60.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29409866/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29409866) |
| :-- | --: |
| Change from base [Build 1089](https://coveralls.io/builds/29409529): | -0.007% |
| Covered Lines: | 12485 |
| Relevant Lines: | 20899 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services