[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2275: refact: adjust pom structure for directly compiling from root

["imbajin (via GitHub)" <gi...@apache.org>]

imbajin commented on code in PR #2275:
URL: https://github.com/apache/incubator-hugegraph/pull/2275#discussion_r1287943259


##########
hugegraph-store/hg-store-core/pom.xml:
##########
@@ -121,9 +121,48 @@
             <version>${revision}</version>
             <scope>system</scope>
             <systemPath>
-                ${project.basedir}/../hg-store-dist/src/assembly/ext-lib/hugegraph-core-1.5.0.jar
+                ${top.level.dir}/hg-store-dist/src/assembly/ext-lib/hugegraph-core-1.5.0.jar
             </systemPath>
         </dependency>
+        <!-- tinkerpop -->
+        <dependency>

Review Comment:
   why we need add tinkerpop dependency here?
   
   @VGalaxies any context?



##########
hugegraph-store/hg-store-core/pom.xml:
##########
@@ -121,9 +121,48 @@
             <version>${revision}</version>
             <scope>system</scope>
             <systemPath>
-                ${project.basedir}/../hg-store-dist/src/assembly/ext-lib/hugegraph-core-1.5.0.jar
+                ${top.level.dir}/hg-store-dist/src/assembly/ext-lib/hugegraph-core-1.5.0.jar

Review Comment:
   add a TODO comment for it  
   
   and unify the param
   <img width="967" alt="image" src="https://github.com/apache/incubator-hugegraph/assets/17706099/e9156218-c1e6-41fb-91d9-ab15f3c42e20">
   



##########
hugegraph-store/pom.xml:
##########
@@ -49,6 +49,7 @@
         <maven.compiler.source>11</maven.compiler.source>
         <maven.compiler.target>11</maven.compiler.target>
         <log4j2.version>2.15.0</log4j2.version>
+        <top.level.dir>${project.basedir}/..</top.level.dir>

Review Comment:
   WARN: ensure we don't have multi `top.level.dir` in project (if we have & need use it, add a comment for it)



##########
hugegraph-store/hg-store-test/pom.xml:
##########
@@ -210,7 +210,15 @@
             <version>${revision}</version>
             <scope>compile</scope>
         </dependency>
-
+        <dependency>

Review Comment:
   ```suggestion
           <!-- TODO: we need replace it with the apache version later -->
           <dependency>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org