You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by chitin <gi...@git.apache.org> on 2017/04/10 09:14:21 UTC
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
GitHub user chitin opened a pull request:
https://github.com/apache/eagle/pull/908
[EAGLE-998]Add eagle csd
Add eagle csd
https://issues.apache.org/jira/browse/EAGLE-998
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chitin/eagle eaglecdh
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/908.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #908
----
commit d98432fa5e9856fee6146ec2b4447c3fb9983ecd
Author: chitin <ch...@gmail.com>
Date: 2017-04-10T09:09:08Z
[EAGLE-998]Add eagle csd
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by chitin <gi...@git.apache.org>.
Github user chitin commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111853964
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
Yes,it's in different format than eagle.conf, one is json file and another is key-value file. Please search eagle.properties in descriptor/service.sdl. Maybe, I can delete eagle_server.sh, and mention the change in README.md.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111862101
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
Cool, Thanks Chitin, hope you have tested this well, since its eagle-external anyway, I will merge this once the ci passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111720746
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
same with server.yml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111720728
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
Do you have to duplicate the eagle-server.sh ? can you fetch it from eagle-assembly/src/main/bin/eagle-server.sh as part of eagle-cdh/assembly.xml ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111856707
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
ok, sure if the format is different, it makes sense, pls remove eagle-server.sh.
i could not find the eagle.properties file in this commit or in the project so i couldnt check on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111810600
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
while packaging this module, can you pick up eagle.conf and copy it as eagle.properties via maven-assembly-plugin since the file content dont change ?
btw, i dont see eagle.properties file in this PR. is it in different format than eagle.conf?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/eagle/pull/908
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by chitin <gi...@git.apache.org>.
Github user chitin commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111864052
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
Thank you very much for your review. I have used it in my company for a long time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #908: [EAGLE-998]Add eagle csd
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/908
was just going through some PRs, so put some comments...pls take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #908: [EAGLE-998]Add eagle csd
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/908
@baibaichen @chitin reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #908: [EAGLE-998]Add eagle csd
Posted by baibaichen <gi...@git.apache.org>.
Github user baibaichen commented on the issue:
https://github.com/apache/eagle/pull/908
@haoch could you have a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by chitin <gi...@git.apache.org>.
Github user chitin commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111723827
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
Thanks for your review. As I mentioned in /scripts/control.sh,"Use eagle.properties instead of eagle.conf, configFormat only support hadoop_xml,properties,gflags", CSD can't generate file end with ".conf", I can't find out better method to replace.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #908: [EAGLE-998]Add eagle csd
Posted by baibaichen <gi...@git.apache.org>.
Github user baibaichen commented on the issue:
https://github.com/apache/eagle/pull/908
@chitin please adding
1. a mvn profile for build CDH parcel
2. readme.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #908: [EAGLE-998]Add eagle csd
Posted by chitin <gi...@git.apache.org>.
Github user chitin commented on a diff in the pull request:
https://github.com/apache/eagle/pull/908#discussion_r111857583
--- Diff: eagle-external/eagle-cdh/src/aux/eagle-server.sh ---
@@ -0,0 +1,135 @@
+#!/bin/bash
--- End diff --
Ok,I'll remove eagle-server.sh,it's very detailed code. And eagle.properties, please review https://github.com/apache/eagle/pull/908/files#diff-712f093104224c501339f2117db3b849R764 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---