[GitHub] [phoenix] gokceni commented on a change in pull request #611: PHOENIX-5535 Replay delete markers during server side global index re…

[GitBox <gi...@apache.org>]

gokceni commented on a change in pull request #611: PHOENIX-5535 Replay delete markers during server side global index re…
URL: https://github.com/apache/phoenix/pull/611#discussion_r339841804
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
 ##########
 @@ -1146,6 +1154,45 @@ private void setMutationAttributes(Mutation m, byte[] uuidValue) {
             m.setDurability(Durability.SKIP_WAL);
         }
 
+        private Delete generateDeleteMarkers(List<Cell> row) {
+            Set<ColumnReference> allColumns = indexMaintainer.getAllColumns();
+            if (row.size() == allColumns.size() + 1) {
 
 Review comment:
   Can we have a comment here why we are returning null when we have 1 more row cell then allColumns?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services