You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Joe Stein (JIRA)" <ji...@apache.org> on 2012/09/12 19:02:07 UTC
[jira] [Created] (KAFKA-508) separate out partiondata from
fetchresponse and producer request
Joe Stein created KAFKA-508:
-------------------------------
Summary: separate out partiondata from fetchresponse and producer request
Key: KAFKA-508
URL: https://issues.apache.org/jira/browse/KAFKA-508
Project: Kafka
Issue Type: Bug
Reporter: Joe Stein
Assignee: Joe Stein
Priority: Blocker
Fix For: 0.8
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Koshy updated KAFKA-508:
-----------------------------
Labels: optimization (was: core)
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Stein closed KAFKA-508.
---------------------------
committed patch removing the extends typo i had left in as Joel caught, thanks!
<< we should be able to remove partition from ProducerRequestPartitionData and FetchResponsePartitionData. Could you elaborate the problem that you saw?
so i see functions getting the partition passed into it without any other way to get the partition except from these 2 objects however, it is possible within those functions it is not needed or is able to get to it some other way. I really need to spend more time with the 0.8 changes which I will do in the coming week. opened JIRA for this can work it all out there.
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch, KAFKA-508.v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469754#comment-13469754 ]
Joel Koshy commented on KAFKA-508:
----------------------------------
+1 - can you remove the extends from the two objects? or is it there for a reason?
It is definitely possible to do away with the partition member, but we can take care of that later.
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch, KAFKA-508.v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Stein updated KAFKA-508:
----------------------------
Attachment: KAFKA-508.patch
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468825#comment-13468825 ]
Jun Rao commented on KAFKA-508:
-------------------------------
Hi, Joe,
Do you still plan to work on this jira? Thanks,
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468865#comment-13468865 ]
Joe Stein commented on KAFKA-508:
---------------------------------
yes, sorry been swamped at work.
looking at where i left off going through this I also am going to breakout TopicData into TopicDataFetchResponse and TopicDataProducerRequest unless we want to keep that structure consistent also for some reason
will work more on this tonight hopefully get a patch out soon
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Stein updated KAFKA-508:
----------------------------
Status: Patch Available (was: Open)
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Stein updated KAFKA-508:
----------------------------
Summary: split out partiondata from fetchresponse and producerrequest (was: separate out partiondata from fetchresponse and producer request)
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: core
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469660#comment-13469660 ]
Joe Stein commented on KAFKA-508:
---------------------------------
<< Actually, do you think we can also get rid of the partition field from the PartitionDataProducerRequest and PartitionDataFetchResponse?
no, i don't think so but maybe I am missing something
<< So we can consider doing this in a separate non-blocker jira as getting the wire protocol change in is more important.
yeah, seperate discussion
<< BTW, personally I prefer ProducerRequestPartitionData "AB" and FetchResponsePartitionData "AB" would be better than "BA". What say?
I originally had it that way and changed it because I thought folks might want it BA, AB is preferable to me patch coming in a sec
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469835#comment-13469835 ]
Jun Rao commented on KAFKA-508:
-------------------------------
Joe, thanks for the patch. Looks good overall. I agree with Joel that we should be able to remove partition from ProducerRequestPartitionData and FetchResponsePartitionData. Could you elaborate the problem that you saw?
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch, KAFKA-508.v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Stein updated KAFKA-508:
----------------------------
Attachment: KAFKA-508.v2.patch
BA patch attached for name change to be
ProducerRequestPartitionData and FetchResponsePartitionData instead of PartitionDataFetchResponse and PartitionDataFetchResponse
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch, KAFKA-508.v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469566#comment-13469566 ]
Joel Koshy commented on KAFKA-508:
----------------------------------
Joe, thanks for the patch. Actually, do you think we can also get rid of
the partition field from the PartitionDataProducerRequest and
PartitionDataFetchResponse? It seems redundant since the map key already
uses (TopicAndPartition). So PartitionDataProducerRequest will become
unnecessary, and PartitionDataFetchResponse can get rid of the partition
member. This shouldn't require further changes to the wire protocol (beyond
your current change), but there are some places in the code that will need to be
fixed. So we can consider doing this in a separate non-blocker jira as
getting the wire protocol change in is more important.
BTW, personally I prefer ProducerRequestPartitionData "AB" and
FetchResponsePartitionData "AB" would be better than "BA". What say?
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468865#comment-13468865 ]
Joe Stein edited comment on KAFKA-508 at 10/4/12 8:39 AM:
----------------------------------------------------------
yes, sorry been swamped at work.
will work more on this tonight hopefully get a patch out soon
was (Author: charmalloc):
yes, sorry been swamped at work.
looking at where i left off going through this I also am going to breakout TopicData into TopicDataFetchResponse and TopicDataProducerRequest unless we want to keep that structure consistent also for some reason
will work more on this tonight hopefully get a patch out soon
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-508) split out partiondata from
fetchresponse and producerrequest
Posted by "Joe Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Stein updated KAFKA-508:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch, KAFKA-508.v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira