You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "Kyofin (via GitHub)" <gi...@apache.org> on 2023/06/17 08:33:28 UTC
[GitHub] [seatunnel] Kyofin opened a new pull request, #4942: checkpoint support hdfs ha mode
Kyofin opened a new pull request, #4942:
URL: https://github.com/apache/seatunnel/pull/4942
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
close issue #4676
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] hailin0 commented on pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942#issuecomment-1596821030
please update docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] liugddx commented on pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942#issuecomment-1676571254
@davidzollo PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942#issuecomment-1668869782
<img width="1008" alt="image" src="https://github.com/apache/seatunnel/assets/83933160/be5ffd80-cb31-49cf-82ea-3cf27d50b1c6">
@Kyofin Please use `mvn spotless:apply` to format the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 commented on pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942#issuecomment-1610638284
Please rerun `mvn spotless:apply` . Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y closed pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y closed pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
URL: https://github.com/apache/seatunnel/pull/4942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Kyofin commented on pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "Kyofin (via GitHub)" <gi...@apache.org>.
Kyofin commented on PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942#issuecomment-1667115502
> Waiting for CI/CD.
need CI/CD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 merged pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 merged PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Hisoka-X commented on a diff in pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942#discussion_r1233664533
##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/hdfs/common/HdfsConfiguration.java:
##########
@@ -69,7 +71,16 @@ public Configuration buildConfiguration(Map<String, String> config)
authenticateKerberos(kerberosPrincipal, kerberosKeytabFilePath, hadoopConf);
}
}
- // todo support other hdfs optional config keys
+ // support other hdfs optional config keys
+ config.entrySet().stream()
+ .filter(entry -> entry.getKey().startsWith(SEATUNNEL_HADOOP_PREFIX))
+ .forEach(
+ entry -> {
+ String key = entry.getKey().replace(SEATUNNEL_HADOOP_PREFIX, "");
+ ;
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942#issuecomment-1666459298
Waiting for CI/CD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #4942: [Feature][Zeta] Checkpoint support hdfs ha mode
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4942:
URL: https://github.com/apache/seatunnel/pull/4942#issuecomment-1672998972
@wu-a-ge
<img width="924" alt="image" src="https://github.com/apache/seatunnel/assets/83933160/26e417f7-0af3-48a4-94b7-bec3286d771a">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org