You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/08/23 10:33:48 UTC

[GitHub] [incubator-pegasus] empiredan opened a new issue, #1587: Fix errors in format string for logging and macro

empiredan opened a new issue, #1587:
URL: https://github.com/apache/incubator-pegasus/issues/1587

   There are some problems in current format string for logging and macro, such as:
   
   ### Still use c-style format string, which would not print the correct messages:
   
   ```c++
        CHECK(false, "unsupported filter type: %d", filter_type);
   ```
   
   
   ### Call to-string method for the classes that have implement `operator<<`: 
   
   ```c++
       CHECK(!in_dropped,
                     "adjust position of existing node({}) failed, this is a bug, partition({}.{})",
                     node.to_string(),
                     config_owner->pid.get_app_id(),
                     config_owner->pid.get_partition_index());
       CHECK(false,
                     "we can't handle this when create backup policy, err({})",
                     err.to_string());
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org

Re: [I] Fix errors in format string for logging and macro [incubator-pegasus]

Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 closed issue #1587: Fix errors in format string for logging and macro
URL: https://github.com/apache/incubator-pegasus/issues/1587


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org