You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Mahadev Konar <ma...@hortonworks.com> on 2011/10/25 10:12:15 UTC

[VOTE] Release ZooKeeper 3.4.0 (candidate 0)

Hi all,
 I have created a 3.4.0 release candidate. 3.4 is the first major
release after ZooKeeper became a TLP.
 The last major release 3.3.0 was done in March, 2010.
 3.4.0 includes a lot of features, improvements and bug fixes. Please
look at Release Notes for more information.

*** Please download, test and VOTE before the
*** vote closes 1am PDT on Tuesday, Nov1***

http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-0/

Should we release this?

Please make sure, you download and test the release ASAP. Early
feedback would be very helpful.

thanks
mahadev

Re: [VOTE] Release ZooKeeper 3.4.0 (candidate 0)

Posted by Mahadev Konar <ma...@hortonworks.com>.
Thanks for pointing out Ivan. That might be a mistake on my side :).
Will fix that.

Again, folks, please try out the release ASAP. We do have a couple of
issues to fix but lets find all the issues we can and then see what we
want to fix in 3.4.0.

thanks
mahadev

On Tue, Oct 25, 2011 at 9:25 AM, Ivan Kelly <iv...@yahoo-inc.com> wrote:
>> the compile warnings are a known issue (not something that should
>> block the release IMO), see this jira I filed:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-1236
> That only refers to the proprietary sun apis. Is there a JIRA that covers the use of Zookeeper's own deprecated classes also?
>>
>> The test failure on macos is unfortunate, but give it's not a
>> "production" platform I don't think it should be considered a blocker
>> (although I may not be in the majority here...)
>> http://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html#sc_systemReq
> Sure, I've just tested on a linux box and it doesn't seem to happen.
>
> I've also just notices that this actual tarball isn't actually gzipped.
>
> $ file zookeeper-3.4.0.tar.gz
> zookeeper-3.4.0.tar.gz: POSIX tar archive
>
> -Ivan
>
>

Re: [VOTE] Release ZooKeeper 3.4.0 (candidate 0)

Posted by Ivan Kelly <iv...@yahoo-inc.com>.
> the compile warnings are a known issue (not something that should
> block the release IMO), see this jira I filed:
> https://issues.apache.org/jira/browse/ZOOKEEPER-1236
That only refers to the proprietary sun apis. Is there a JIRA that covers the use of Zookeeper's own deprecated classes also?
> 
> The test failure on macos is unfortunate, but give it's not a
> "production" platform I don't think it should be considered a blocker
> (although I may not be in the majority here...)
> http://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html#sc_systemReq
Sure, I've just tested on a linux box and it doesn't seem to happen.

I've also just notices that this actual tarball isn't actually gzipped. 

$ file zookeeper-3.4.0.tar.gz 
zookeeper-3.4.0.tar.gz: POSIX tar archive

-Ivan


Re: [VOTE] Release ZooKeeper 3.4.0 (candidate 0)

Posted by Patrick Hunt <ph...@apache.org>.
Thanks for trying out the release Ivan!

the compile warnings are a known issue (not something that should
block the release IMO), see this jira I filed:
https://issues.apache.org/jira/browse/ZOOKEEPER-1236

I believe Thomas has removed a lot of tabs from trunk... (not a blocker).

The test failure on macos is unfortunate, but give it's not a
"production" platform I don't think it should be considered a blocker
(although I may not be in the majority here...)
http://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html#sc_systemReq

However I do notice that solaris is failing consistently (granted
trunk but likely the same issue in 3.4)
https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_trunk_solaris/

I'll let the release manager decide on whether solaris is a blocker or
if he just wants to release note it (and fix in 3.4.1) - Mahadev?

Patrick

On Tue, Oct 25, 2011 at 3:12 AM, Ivan Kelly <iv...@yahoo-inc.com> wrote:
> -1
>
> The distributed binaries work for starting a server client etc.
>
> I get compile warnings:
>
> compile:
>    [javac] Compiling 145 source files to /Users/ivank/Junk/zookeeper-3.4.0/build/classes
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/Shell.java:276: warning: [serial] serializable class org.apache.zookeeper.Shell.ExitCodeException has no definition of serialVersionUID
>    [javac]   public static class ExitCodeException extends IOException {
>    [javac]                 ^
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:573: warning: [deprecation] org.apache.zookeeper.server.quorum.LeaderElection in org.apache.zookeeper.server.quorum has been deprecated
>    [javac]             le = new LeaderElection(this);
>    [javac]                      ^
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:576: warning: [deprecation] org.apache.zookeeper.server.quorum.AuthFastLeaderElection in org.apache.zookeeper.server.quorum has been deprecated
>    [javac]             le = new AuthFastLeaderElection(this);
>    [javac]                      ^
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:579: warning: [deprecation] org.apache.zookeeper.server.quorum.AuthFastLeaderElection in org.apache.zookeeper.server.quorum has been deprecated
>    [javac]             le = new AuthFastLeaderElection(this, true);
>    [javac]                      ^
>    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:600: warning: [deprecation] org.apache.zookeeper.server.quorum.LeaderElection in org.apache.zookeeper.server.quorum has been deprecated
>    [javac]             electionAlg = new LeaderElection(this);
>    [javac]                               ^
>    [javac] 5 warnings
>
> The first one can be fixed with "static final long serialVersionUID = 2977863941654513113L;". The deprecation may be a bit more involved though. You could suppress the warning, but really you should just remove the use of a deprecated class.
>
> Also, while looking into that, I saw QuorumPeer.java has tabs in it.
>
> org.apache.zookeeper.test.ClientPortBindTest fails, consistently.
>
> This is on Mac OS 10.6.8
> $ java -version
> java version "1.6.0_26"
> Java(TM) SE Runtime Environment (build 1.6.0_26-b03-384-10M3425)
> Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02-384, mixed mode)
>
> $ uname -a
> Darwin spokegrown-lm 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun  7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386
>
> -Ivan
>
>
> On 25 Oct 2011, at 10:12, Mahadev Konar wrote:
>
>> Hi all,
>> I have created a 3.4.0 release candidate. 3.4 is the first major
>> release after ZooKeeper became a TLP.
>> The last major release 3.3.0 was done in March, 2010.
>> 3.4.0 includes a lot of features, improvements and bug fixes. Please
>> look at Release Notes for more information.
>>
>> *** Please download, test and VOTE before the
>> *** vote closes 1am PDT on Tuesday, Nov1***
>>
>> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-0/
>>
>> Should we release this?
>>
>> Please make sure, you download and test the release ASAP. Early
>> feedback would be very helpful.
>>
>> thanks
>> mahadev
>
>

Re: [VOTE] Release ZooKeeper 3.4.0 (candidate 0)

Posted by Ivan Kelly <iv...@yahoo-inc.com>.
-1

The distributed binaries work for starting a server client etc.

I get compile warnings:

compile:
    [javac] Compiling 145 source files to /Users/ivank/Junk/zookeeper-3.4.0/build/classes
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/Shell.java:276: warning: [serial] serializable class org.apache.zookeeper.Shell.ExitCodeException has no definition of serialVersionUID
    [javac]   public static class ExitCodeException extends IOException {
    [javac]                 ^
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:573: warning: [deprecation] org.apache.zookeeper.server.quorum.LeaderElection in org.apache.zookeeper.server.quorum has been deprecated
    [javac]             le = new LeaderElection(this);
    [javac]                      ^
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:576: warning: [deprecation] org.apache.zookeeper.server.quorum.AuthFastLeaderElection in org.apache.zookeeper.server.quorum has been deprecated
    [javac]             le = new AuthFastLeaderElection(this);
    [javac]                      ^
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:579: warning: [deprecation] org.apache.zookeeper.server.quorum.AuthFastLeaderElection in org.apache.zookeeper.server.quorum has been deprecated
    [javac]             le = new AuthFastLeaderElection(this, true);
    [javac]                      ^
    [javac] /Users/ivank/Junk/zookeeper-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java:600: warning: [deprecation] org.apache.zookeeper.server.quorum.LeaderElection in org.apache.zookeeper.server.quorum has been deprecated
    [javac]             electionAlg = new LeaderElection(this);
    [javac]                               ^
    [javac] 5 warnings

The first one can be fixed with "static final long serialVersionUID = 2977863941654513113L;". The deprecation may be a bit more involved though. You could suppress the warning, but really you should just remove the use of a deprecated class. 

Also, while looking into that, I saw QuorumPeer.java has tabs in it.

org.apache.zookeeper.test.ClientPortBindTest fails, consistently.

This is on Mac OS 10.6.8
$ java -version
java version "1.6.0_26"
Java(TM) SE Runtime Environment (build 1.6.0_26-b03-384-10M3425)
Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02-384, mixed mode)

$ uname -a
Darwin spokegrown-lm 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun  7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386

-Ivan


On 25 Oct 2011, at 10:12, Mahadev Konar wrote:

> Hi all,
> I have created a 3.4.0 release candidate. 3.4 is the first major
> release after ZooKeeper became a TLP.
> The last major release 3.3.0 was done in March, 2010.
> 3.4.0 includes a lot of features, improvements and bug fixes. Please
> look at Release Notes for more information.
> 
> *** Please download, test and VOTE before the
> *** vote closes 1am PDT on Tuesday, Nov1***
> 
> http://people.apache.org/~mahadev/zookeeper-3.4.0-candidate-0/
> 
> Should we release this?
> 
> Please make sure, you download and test the release ASAP. Early
> feedback would be very helpful.
> 
> thanks
> mahadev