You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Kcruz28 (via GitHub)" <gi...@apache.org> on 2025/10/17 02:35:34 UTC

[PR] Fix/2.x/flaky syslog appender test base [logging-log4j2]

Kcruz28 opened a new pull request, #3956:
URL: https://github.com/apache/logging-log4j2/pull/3956

   I increased the Awaitility wait in `AbstractAsyncThreadContextTestBase` from 500 ms to 5 seconds to avoid a timing flake where the async logger ring buffer was not freed quickly enough on some machines. This is a minimal, test only change that keeps the same assertions but gives more time for slow or busy CI runners, especially on Windows. Five seconds should absorb temporary scheduling or I/O delays while keeping tests fast. We can adjust the timeout or make it configurable later if needed.
   
   Fixes #3005 
   
   > [!IMPORTANT]  
   > Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise.
   
   ## Checklist
   
   Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
   
   ### ✅ Required checks
   
   - [ ] **License**: I confirm that my changes are submitted under the [Apache License, Version 2.0](https://apache.org/licenses/LICENSE-2.0).
   - [ ] **Commit signatures**: All commits are signed and verifiable. (See [GitHub Docs on Commit Signature Verification](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)).
   - [ ] **Code formatting**: The code is formatted according to the project’s style guide.
     <details>
       <summary>How to check and fix formatting</summary>
   
       - To **check** formatting: `./mvnw spotless:check`
       - To **fix** formatting: `./mvnw spotless:apply`
   
       See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
     </details>
   - [ ] **Build & Test**: I verified that the project builds and all unit tests pass.
     <details>
       <summary>How to build the project</summary>
   
       Run: `./mvnw verify`
   
       See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
     </details>
   
   ### 🧪 Tests (select one)
   
   - [ ] I have added or updated tests to cover my changes.
   - [ ] No additional tests are needed for this change.
   
   ### 📝 Changelog (select one)
   
   - [ ] I added a changelog entry in `src/changelog/.2.x.x`. (See [Changelog Entry File Guide](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file)).
   - [ ] This is a trivial change and does not require a changelog entry.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Increase Awaitility timeout to 5s in `AbstractAsyncThreadContextTestBase` [logging-log4j2]

Posted by "Kcruz28 (via GitHub)" <gi...@apache.org>.
Kcruz28 commented on PR #3956:
URL: https://github.com/apache/logging-log4j2/pull/3956#issuecomment-3419101170

   No problem! I’ve signed all my commits. Everything should be ready now. Please let me know if you encounter any issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Increase Awaitility timeout to 5s in `AbstractAsyncThreadContextTestBase` [logging-log4j2]

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #3956:
URL: https://github.com/apache/logging-log4j2/pull/3956


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Increase Awaitility timeout to 5s in `AbstractAsyncThreadContextTestBase` [logging-log4j2]

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #3956:
URL: https://github.com/apache/logging-log4j2/pull/3956#issuecomment-3415696457

   @Kcruz28, thanks so much for the contribution. Would you mind [signing all your commits](https://chatgpt.com/share/689f0f3a-22b8-8002-90d7-6b7c1d702ffa), please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Increase Awaitility timeout to 5s in `AbstractAsyncThreadContextTestBase` [logging-log4j2]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3956:
URL: https://github.com/apache/logging-log4j2/pull/3956#issuecomment-3421058636

   
   
   <table>
       <tr>
           <th>Job</th>
           <th>Requested goals</th>
           <th>Build Tool Version</th>
           <th>Build Outcome</th>
           <th>Build Scan®</th>
       </tr>
       <tr>
           <td>build-macos-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:white_check_mark:</td>
           <td><a href="https://develocity.apache.org/s/lltyxruobcde6" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
       <tr>
           <td>build-ubuntu-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:x:</td>
           <td><a href="https://develocity.apache.org/s/3wz6poc7iu56w" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
       <tr>
           <td>build-windows-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:white_check_mark:</td>
           <td><a href="https://develocity.apache.org/s/k4cv7bmhhbdnq" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
   </table>
       
   
   ###### Generated by gradle/develocity-actions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org