You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2008/03/23 00:25:24 UTC
[jira] Created: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Event Listeners called before request handlers are informed of SolrCore
-----------------------------------------------------------------------
Key: SOLR-509
URL: https://issues.apache.org/jira/browse/SOLR-509
Project: Solr
Issue Type: Bug
Components: search
Reporter: Hoss Man
Fix For: 1.3
http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593960#action_12593960 ]
Koji Sekiguchi commented on SOLR-509:
-------------------------------------
I confirmed the fix. I like the second patch (uses a latch version). Thanks Yonik to solve this problem!
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509-fix.patch, SOLR-509-fix.patch, SOLR-509.patch, SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley reopened SOLR-509:
-------------------------------
Reopening... This patch introduced a bug that prevents the first searcher opened from ever being closed.
I'm looking into a fix.
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509.patch, SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589708#action_12589708 ]
Grant Ingersoll commented on SOLR-509:
--------------------------------------
FWIW, applies cleanly and the tests pass. As for the future, I guess I say we wait until it happens. I can add a comment.
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-509.
-------------------------------
Resolution: Fixed
Assignee: Yonik Seeley (was: Grant Ingersoll)
fix committed.
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Yonik Seeley
> Fix For: 1.3
>
> Attachments: SOLR-509-fix.patch, SOLR-509-fix.patch, SOLR-509.patch, SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589699#action_12589699 ]
Yonik Seeley commented on SOLR-509:
-----------------------------------
firstSearcher should be called whenever a new searcher is being opened and there is no current searcher to base warming on. Right now, that will only happen at startup, but in the future?
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi updated SOLR-509:
--------------------------------
Attachment: SOLR-509.patch
How about this?
1. move firsrSearcher processing block from getSearcher() to a newly created private method
2. call the new private method at the end of SolrCore constructor
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Fix For: 1.3
>
> Attachments: SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll reassigned SOLR-509:
------------------------------------
Assignee: Grant Ingersoll
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll resolved SOLR-509.
----------------------------------
Resolution: Fixed
Committed revision 649046.
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509.patch, SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll updated SOLR-509:
---------------------------------
Attachment: SOLR-509.patch
I'll commit this shortly. Added to CHANGES and put in a comment about calls to firstSearcher initialization.
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509.patch, SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-509:
------------------------------
Attachment: SOLR-509-fix.patch
This is one possible (untested) fix.
I didn't test it because I'm looking into something that might be a bit better.... just stall the executor until later.
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509-fix.patch, SOLR-509.patch, SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-509:
------------------------------
Attachment: SOLR-509-fix.patch
Here's the latest version, which restores firstSearcher event handling to getSearcher, and uses a latch to block any searcher warming events until the end of the SolrCore constructor.
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509-fix.patch, SOLR-509-fix.patch, SOLR-509.patch, SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-509) Event Listeners called before request
handlers are informed of SolrCore
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589718#action_12589718 ]
Thijs Vonk commented on SOLR-509:
---------------------------------
there is a small typo in your patch
//TODO: It may not always be the case that this the only time the first searcher event needs to fire.
doFirstSearcherEvent(getSearcher().get());
//TODO: It may not always be the case that this is the only time the first searcher event needs to fire.
doFirstSearcherEvent(getSearcher().get());
> Event Listeners called before request handlers are informed of SolrCore
> -----------------------------------------------------------------------
>
> Key: SOLR-509
> URL: https://issues.apache.org/jira/browse/SOLR-509
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Hoss Man
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: SOLR-509.patch, SOLR-509.patch
>
>
> http://www.nabble.com/Nullpointer-when-using-QuerySenderListener-to16201207.html
> Thijs noticed NullPointerException from SearchHandler on startup when trying to configure some firstSearcher events using QuerySenderListener.
> The problem is the events are getting triggered as soon as the firstSearcher is opened, but the SOlrCore isn't finished being initialized, so inform(SolrCore) hasn't been called on all the Handlers (and some handlers aren't fully initialized and ready to process requests yet.
> We need to more the firstSearcher event handling after inform has been called on all SolrCoreAware objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.