[GitHub] [nuttx] julianoes opened a new pull request, #8536: STM32H7 socketcan extended filter fixes

["julianoes (via GitHub)" <gi...@apache.org>]

julianoes opened a new pull request, #8536:
URL: https://github.com/apache/nuttx/pull/8536

   ## Summary
   
   When I checked how this register was set I discovered that 128 was not
   accepted by the H7 but 64 was ok. Looking at the STM32Cube's HAL it
   seems to be only 64 words long, however, the reference manual claims
   otherwise.
   
   I have opened a discussion on the ST community forum
   https://community.st.com/s/question/0D73W000001nzqFSAQ
   but unfortunately not received an answer yet.
   
   In the meantime, I think, we should update this to what I found to be
   working though.
   
   ## Impact
   
   I expect this to help to get socketcan working on H7.
   
   ## Testing
   
   I've tested this on a board but it would be great if someone could cross test this on another platform, if possible.
   
   FYI @davids5 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8536: STM32H7 socketcan extended filter fixes

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #8536:
URL: https://github.com/apache/nuttx/pull/8536


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] davids5 commented on a diff in pull request #8536: STM32H7 socketcan extended filter fixes

["davids5 (via GitHub)" <gi...@apache.org>]

davids5 commented on code in PR #8536:
URL: https://github.com/apache/nuttx/pull/8536#discussion_r1106733563


##########
arch/arm/src/stm32h7/stm32_fdcan_sock.c:
##########
@@ -2236,9 +2236,20 @@ int fdcan_initialize(struct fdcan_driver_s *priv)
   putreg32(regval, priv->base + STM32_FDCAN_SIDFC_OFFSET);
   ram_offset += n_stdid;
 
-  /* Extended ID Filters: Allow space for 128 filters (128 words) */
+  /* Extended ID Filters: Allow space for 64 filters (64 words)
+   * The reference manual claims that 128 words are possible, but in

Review Comment:
   ```suggestion
      * The register definition of FDCAN_XIDFC:LSE - List size extended, in the reference manual (RM0433 Rev 8) is defined as 8 bits and claims that a value of 0-128 (Number of extended ID filter elements) are possible, but in the text in section 56.4.22 and in
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org