[GitHub] [spark] yaooqinn commented on a change in pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeRepl…

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #28420:
URL: https://github.com/apache/spark/pull/28420#discussion_r417827135



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1206,7 +1207,7 @@ case class DatetimeSub(
     interval: Expression,
     child: Expression) extends RuntimeReplaceable {
   override def toString: String = s"$start - $interval"
-  override def sql: String = s"${start.sql} - ${interval.sql}"
+  override def sql: String = s"${toPrettySQL(start)} - ${toPrettySQL(interval)}"

Review comment:
       OK, let me see

##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1206,7 +1207,7 @@ case class DatetimeSub(
     interval: Expression,
     child: Expression) extends RuntimeReplaceable {
   override def toString: String = s"$start - $interval"
-  override def sql: String = s"${start.sql} - ${interval.sql}"
+  override def sql: String = s"${toPrettySQL(start)} - ${toPrettySQL(interval)}"

Review comment:
       OK, let me see




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org