You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/05 16:34:19 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1898: combine logback config of master/worker/alert/api server to one
codecov-io edited a comment on issue #1898: combine logback config of master/worker/alert/api server to one
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1898#issuecomment-582494245
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898?src=pr&el=h1) Report
> Merging [#1898](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/c6d1557a2befd6195ba4bac36dba23eaae54ca53?src=pr&el=desc) will **decrease** coverage by `0.58%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1898 +/- ##
==========================================
- Coverage 22.47% 21.89% -0.59%
==========================================
Files 296 296
Lines 14176 14261 +85
Branches 2340 2376 +36
==========================================
- Hits 3186 3122 -64
- Misses 10635 10782 +147
- Partials 355 357 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...phinscheduler/common/log/TaskLogDiscriminator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2xvZy9UYXNrTG9nRGlzY3JpbWluYXRvci5qYXZh) | `70% <ø> (ø)` | |
| [...e/dolphinscheduler/common/log/MasterLogFilter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2xvZy9NYXN0ZXJMb2dGaWx0ZXIuamF2YQ==) | `16.66% <ø> (ø)` | |
| [...he/dolphinscheduler/server/utils/ProcessUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1Byb2Nlc3NVdGlscy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/common/log/WorkerLogFilter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2xvZy9Xb3JrZXJMb2dGaWx0ZXIuamF2YQ==) | `16.66% <ø> (ø)` | |
| [...che/dolphinscheduler/common/log/TaskLogFilter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2xvZy9UYXNrTG9nRmlsdGVyLmphdmE=) | `16.66% <ø> (ø)` | |
| [...duler/server/worker/runner/TaskScheduleThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza1NjaGVkdWxlVGhyZWFkLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...lphinscheduler/common/utils/SensitiveLogUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWxzLmphdmE=) | `100% <ø> (ø)` | |
| [...che/dolphinscheduler/common/utils/LoggerUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0xvZ2dlclV0aWxzLmphdmE=) | `92.85% <100%> (ø)` | |
| [...inscheduler/common/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2xvZy9TZW5zaXRpdmVEYXRhQ29udmVydGVyLmphdmE=) | `94.11% <100%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898?src=pr&el=footer). Last update [c6d1557...8ab680f](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1898?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services