You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@gluten.apache.org by "taiyang-li (via GitHub)" <gi...@apache.org> on 2025/01/06 08:08:24 UTC

Re: [PR] [GLUTEN-8343][CH]Fix cast number to decimal [incubator-gluten]

taiyang-li commented on code in PR #8351:
URL: https://github.com/apache/incubator-gluten/pull/8351#discussion_r1903803591


##########
cpp-ch/local-engine/Functions/SparkFunctionCheckDecimalOverflow.cpp:
##########
@@ -146,17 +156,18 @@ class FunctionCheckDecimalOverflow : public IFunction
     }
 
 private:
-    template <typename T, typename ToDataType>
+    template <typename FromDataType, typename ToDataType, typename ColVecType, typename T = FromDataType::FieldType>

Review Comment:
   why not remove T and add "using T = typename FromDataType::FieldType" below



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org