[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a change in pull request #186: HLL allocator

[GitBox <gi...@apache.org>]

AlexanderSaydakov commented on a change in pull request #186:
URL: https://github.com/apache/datasketches-cpp/pull/186#discussion_r574002759



##########
File path: hll/include/Hll4Array-internal.hpp
##########
@@ -315,12 +316,12 @@ void Hll4Array<A>::shiftToBiggerCurMin() {
 
 template<typename A>
 typename HllArray<A>::const_iterator Hll4Array<A>::begin(bool all) const {
-  return typename HllArray<A>::const_iterator(this->hllByteArr, 1 << this->lgConfigK, 0, this->tgtHllType, auxHashMap, this->curMin, all);
+  return typename HllArray<A>::const_iterator(this->hllByteArr.data(), 1 << this->lgConfigK, 0, this->tgtHllType, auxHashMap, this->curMin, all);

Review comment:
       Perhaps. It is purely cosmetic and internal. Let's not worry about this right now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org