You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "wuwen5 (via GitHub)" <gi...@apache.org> on 2023/10/13 09:35:50 UTC
[I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
wuwen5 opened a new issue, #7461:
URL: https://github.com/apache/rocketmq/issues/7461
### Before Creating the Enhancement Request
- [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.
### Summary
https://github.com/apache/rocketmq/blob/2113fa371b9c2bf7c512f8ad234e51c616f1362c/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java#L1224-L1228
If this is `Deprecated`, how do you replace the following code in the sample?
Is there an alternative method before it `Deprecated`
https://github.com/apache/rocketmq/blob/2113fa371b9c2bf7c512f8ad234e51c616f1362c/example/src/main/java/org/apache/rocketmq/example/tracemessage/OpenTracingTransactionProducer.java#L46-L55
### Motivation
Remove `@Deprecated` markers
### Describe the Solution You'd Like
Remove `@Deprecated` markers before new methods are provided
### Describe Alternatives You've Considered
Remove `@Deprecated` markers
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 commented on issue #7461:
URL: https://github.com/apache/rocketmq/issues/7461#issuecomment-1766050783
#7128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
Posted by "sdoqwer1poiu (via GitHub)" <gi...@apache.org>.
sdoqwer1poiu commented on issue #7461:
URL: https://github.com/apache/rocketmq/issues/7461#issuecomment-3133442288
赞同呀，没有新方法前就不应该加这种注解啊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan commented on issue #7461:
URL: https://github.com/apache/rocketmq/issues/7461#issuecomment-1766043759
now, you can use this method, when delete this method (Incompatible，when show in release note) , there will provide a new method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan commented on issue #7461:
URL: https://github.com/apache/rocketmq/issues/7461#issuecomment-1765405745
because expose the getDefaultMQProducerImpl is not necessary. Unless you need to implement the trace yourself in your demo.
just see the commit
https://github.com/apache/rocketmq/commit/6afe0f84fc216f85b12cb7b3cd3d0d168842d65d#diff-cdd8435ff8a2ddc656c64100a9f53df78ab24de78cd45908d6d6bb10826298d3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 commented on issue #7461:
URL: https://github.com/apache/rocketmq/issues/7461#issuecomment-1766037832
How to register a custom hook，Is there any other way to register hooks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 closed issue #7461: [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced?
URL: https://github.com/apache/rocketmq/issues/7461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org