You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Paulex Yang (JIRA)" <ji...@apache.org> on 2006/05/18 08:33:07 UTC
[jira] Created: (HARMONY-475) java.util.Calendar.clone() does not
deep clone the time zone
java.util.Calendar.clone() does not deep clone the time zone
------------------------------------------------------------
Key: HARMONY-475
URL: http://issues.apache.org/jira/browse/HARMONY-475
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Paulex Yang
Priority: Minor
The test case below shows that Calendar should deep clone time zone field, but Harmony doesn't.
public void test_clone() {
Calendar cal = Calendar.getInstance();
cal.set(2006, 5, 6, 11, 35);
Calendar anotherCal = (Calendar) cal.clone();
// should be deep clone
assertTrue(cal.getTimeZone() != anotherCal.getTimeZone());
}
RI 5.0 passes
Harmony fails
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-475) java.util.Calendar.clone() does not
deep clone the time zone
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-475?page=all ]
Stepan Mishura closed HARMONY-475:
----------------------------------
Verified by Paulex.
> java.util.Calendar.clone() does not deep clone the time zone
> ------------------------------------------------------------
>
> Key: HARMONY-475
> URL: http://issues.apache.org/jira/browse/HARMONY-475
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: 01.harmony475.diff
>
> The test case below shows that Calendar should deep clone time zone field, but Harmony doesn't.
> public void test_clone() {
> Calendar cal = Calendar.getInstance();
> cal.set(2006, 5, 6, 11, 35);
> Calendar anotherCal = (Calendar) cal.clone();
> // should be deep clone
> assertTrue(cal.getTimeZone() != anotherCal.getTimeZone());
> }
> RI 5.0 passes
> Harmony fails
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-475) java.util.Calendar.clone() does not
deep clone the time zone
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-475?page=all ]
Stepan Mishura reassigned HARMONY-475:
--------------------------------------
Assign To: Stepan Mishura
> java.util.Calendar.clone() does not deep clone the time zone
> ------------------------------------------------------------
>
> Key: HARMONY-475
> URL: http://issues.apache.org/jira/browse/HARMONY-475
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: 01.harmony475.diff
>
> The test case below shows that Calendar should deep clone time zone field, but Harmony doesn't.
> public void test_clone() {
> Calendar cal = Calendar.getInstance();
> cal.set(2006, 5, 6, 11, 35);
> Calendar anotherCal = (Calendar) cal.clone();
> // should be deep clone
> assertTrue(cal.getTimeZone() != anotherCal.getTimeZone());
> }
> RI 5.0 passes
> Harmony fails
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-475) java.util.Calendar.clone() does not
deep clone the time zone
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-475?page=comments#action_12412333 ]
Paulex Yang commented on HARMONY-475:
-------------------------------------
looks fine, thank you, Stepan.
> java.util.Calendar.clone() does not deep clone the time zone
> ------------------------------------------------------------
>
> Key: HARMONY-475
> URL: http://issues.apache.org/jira/browse/HARMONY-475
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: 01.harmony475.diff
>
> The test case below shows that Calendar should deep clone time zone field, but Harmony doesn't.
> public void test_clone() {
> Calendar cal = Calendar.getInstance();
> cal.set(2006, 5, 6, 11, 35);
> Calendar anotherCal = (Calendar) cal.clone();
> // should be deep clone
> assertTrue(cal.getTimeZone() != anotherCal.getTimeZone());
> }
> RI 5.0 passes
> Harmony fails
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-475) java.util.Calendar.clone() does not
deep clone the time zone
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-475?page=all ]
Stepan Mishura resolved HARMONY-475:
------------------------------------
Resolution: Fixed
Thanks Paulex,
Updated patch was applied to LUNI module at r407526. (I've replaced assertTrue with assertNotSame)
Please check that the patch was applied as you expected.
> java.util.Calendar.clone() does not deep clone the time zone
> ------------------------------------------------------------
>
> Key: HARMONY-475
> URL: http://issues.apache.org/jira/browse/HARMONY-475
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Assignee: Stepan Mishura
> Priority: Minor
> Attachments: 01.harmony475.diff
>
> The test case below shows that Calendar should deep clone time zone field, but Harmony doesn't.
> public void test_clone() {
> Calendar cal = Calendar.getInstance();
> cal.set(2006, 5, 6, 11, 35);
> Calendar anotherCal = (Calendar) cal.clone();
> // should be deep clone
> assertTrue(cal.getTimeZone() != anotherCal.getTimeZone());
> }
> RI 5.0 passes
> Harmony fails
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-475) java.util.Calendar.clone() does not
deep clone the time zone
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-475?page=all ]
Paulex Yang updated HARMONY-475:
--------------------------------
Attachment: 01.harmony475.diff
please try this patch, thanks.
> java.util.Calendar.clone() does not deep clone the time zone
> ------------------------------------------------------------
>
> Key: HARMONY-475
> URL: http://issues.apache.org/jira/browse/HARMONY-475
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Paulex Yang
> Priority: Minor
> Attachments: 01.harmony475.diff
>
> The test case below shows that Calendar should deep clone time zone field, but Harmony doesn't.
> public void test_clone() {
> Calendar cal = Calendar.getInstance();
> cal.set(2006, 5, 6, 11, 35);
> Calendar anotherCal = (Calendar) cal.clone();
> // should be deep clone
> assertTrue(cal.getTimeZone() != anotherCal.getTimeZone());
> }
> RI 5.0 passes
> Harmony fails
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira