You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/10/23 14:37:58 UTC
[GitHub] [maven-javadoc-plugin] slawekjaranowski opened a new pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
slawekjaranowski opened a new pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104
Because user can't do nothing with such message, and exception don't break execution,
logging in verbose mode with stacktrace will be enough.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r735145022
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,16 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ Throwable cause = e;
+ while ( cause.getCause() != null )
+ {
+ cause = cause.getCause();
+ }
+
+ getLog().debug( "resolve path for: " + artifactFile + " cause error: " + e );
Review comment:
I see, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r735090904
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );
Review comment:
probably it is another issue that plugin don't set `JdkHome` .. all test pass so such behavior is not coverage by regression ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] cowwoc edited a comment on pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
cowwoc edited a comment on pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#issuecomment-1014134830
@rfscholte Are you sure that `<jdkToolchain>` works properly? @slawekjaranowski mentioned there are no tests for it and when I run the following with JDK 8:
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.3.1</version>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
<configuration>
<jdkToolchain>
<version>11</version>
</jdkToolchain>
<!-- ... --->
</execution>
</executions>
</plugin>
```
I get:
```
[INFO] Toolchain in maven-javadoc-plugin: JDK[C:\Program Files\Java\jdk-11.0.2]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar (attach-javadocs) on project core: Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar failed.
[...]
Caused by: java.lang.UnsupportedOperationException
at org.codehaus.plexus.languages.java.jpms.CmdModuleNameExtractor.getModuleName (CmdModuleNameExtractor.java:46)
```
I also tried running against `3.3.2-SNAPSHOT` from Maven Central and got the same result.
The exception seems to imply that JDK 8 is being used in spite of the JDK 11 toolchain resolving properly. Should I open a separate bug report for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski merged pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r734981945
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );
Review comment:
type in `resove` (missing the L)
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );
Review comment:
Don't write the stacktrace, it is not useful. If the message is empty, it must be fixed in plexus-java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#issuecomment-976321661
Thanks for approval, so please merge and process jira issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r734987918
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,16 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ Throwable cause = e;
+ while ( cause.getCause() != null )
+ {
+ cause = cause.getCause();
+ }
+
+ getLog().debug( "resolve path for: " + artifactFile + " cause error: " + e );
Review comment:
discovered an existing bug here: `e` should be `cause`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] cowwoc commented on pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
cowwoc commented on pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#issuecomment-1014134830
@rfscholte Are you sure that `<jdkToolchain>` works properly? @slawekjaranowski mentioned there are no tests for it and when I run the following with JDK 8:
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.3.1</version>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
<configuration>
<jdkToolchain>
<version>11</version>
</jdkToolchain>
<!-- ... --->
</execution>
</executions>
</plugin>
```
I get:
```
[INFO] Toolchain in maven-javadoc-plugin: JDK[C:\Program Files\Java\jdk-11.0.2]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar (attach-javadocs) on project core: Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar failed.
[...]
Caused by: java.lang.UnsupportedOperationException
at org.codehaus.plexus.languages.java.jpms.CmdModuleNameExtractor.getModuleName (CmdModuleNameExtractor.java:46)
```
The exception seems to imply that JDK 8 is being used in spite of the JDK 11 toolchain resolving properly. Should I open a separate bug report for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r734984105
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );
Review comment:
Implementation in plexus-java for jdk < 9 is:
https://github.com/codehaus-plexus/plexus-languages/blob/e1450e99c53e45a4935f4bd65b4349877d6cdbb1/plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/CmdModuleNameExtractor.java#L44-L47
What is your proposition for code here?
we can provide some message for `UnsupportedOperationException` in plexus-java ... but logging warn here is too talkative, it look like standard flow for detecting modules support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r734986404
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );
Review comment:
The problem is that if there's no module descriptor nor Manifest file with an Automatic-Module-Name, you need Java 9 code to get the module name based on the filename. So you must set in JdkHome in the request if you're not running with Java 9+.
The plugin is responsible to set this up correctly.
IIRC due to a recent change this method became exposed, otherwise it would never occur. So better to improve the message of the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r735147882
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );
Review comment:
It seems more complicated, i don't see any test for toolchains in project, so it should be done as separate bigger issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r735114446
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,16 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ Throwable cause = e;
+ while ( cause.getCause() != null )
+ {
+ cause = cause.getCause();
+ }
+
+ getLog().debug( "resolve path for: " + artifactFile + " cause error: " + e );
Review comment:
I don't exactly understood your comments, do you want change message of `.debug("...")`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r735133627
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,16 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ Throwable cause = e;
+ while ( cause.getCause() != null )
+ {
+ cause = cause.getCause();
+ }
+
+ getLog().debug( "resolve path for: " + artifactFile + " cause error: " + e );
Review comment:
The purpose it to log the message of the root cause, so it should be
`getLog().debug( "resolve path for: " + artifactFile + " cause error: " + cause );`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] rfscholte commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r735133806
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
}
catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
{
- Throwable cause = e;
- while ( cause.getCause() != null )
+ if ( getLog().isDebugEnabled() )
{
- cause = cause.getCause();
+ getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );
Review comment:
JdkHome should only be set when using ToolChain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#issuecomment-950164509
@rfscholte please look, you last fix plugin fo java modules - MJAVADOC-568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] cowwoc edited a comment on pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
cowwoc edited a comment on pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#issuecomment-1014134830
@rfscholte Are you sure that `<jdkToolchain>` works properly? @slawekjaranowski mentioned there are no tests for it and when I run the following with JDK 8:
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.3.1</version>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
<configuration>
<jdkToolchain>
<version>11</version>
</jdkToolchain>
<!-- ... --->
</execution>
</executions>
</plugin>
```
I get:
```
[INFO] Toolchain in maven-javadoc-plugin: JDK[C:\Program Files\Java\jdk-11.0.2]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar (attach-javadocs) on project core: Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar failed.
[...]
Caused by: java.lang.UnsupportedOperationException
at org.codehaus.plexus.languages.java.jpms.CmdModuleNameExtractor.getModuleName (CmdModuleNameExtractor.java:46)
```
I tried running against `3.3.2-SNAPSHOT` from Maven Central and got the same result.
The exception seems to imply that JDK 8 is being used in spite of the JDK 11 toolchain resolving properly. Should I open a separate bug report for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] cowwoc edited a comment on pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult
Posted by GitBox <gi...@apache.org>.
cowwoc edited a comment on pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#issuecomment-1014134830
@rfscholte I don't think that `<jdkToolchain>` works as expected. I filed https://issues.apache.org/jira/browse/MJAVADOC-704 related to this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org