You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2024/02/21 09:27:54 UTC
[PR] [fix](memory) Fix LRU cache frequent prune [doris]
xinyiZzz opened a new pull request, #31220:
URL: https://github.com/apache/doris/pull/31220
## Proposed changes
Memory GC and periodic thread will prune LRU cache, and will hold cache lock when prune.
If the cache is frequently written, frequent prune cache will affect performance and block memory GC.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956700653
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit fc85b16ad962937379c38c7ccbfeef3619f8e981 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select: 13.6 seconds inserted 10000000 Rows, about 735K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #31220:
URL: https://github.com/apache/doris/pull/31220#discussion_r1497487981
##########
be/src/olap/olap_server.cpp:
##########
@@ -287,6 +286,16 @@ void StorageEngine::_cache_clean_callback() {
} else {
_clear_segment_cache = false;
}
+ if (config::disable_storage_page_cache) {
Review Comment:
// Dynamically modify the config to clear the cache, each time the disable cache will only be cleared once.
这里实际提供了一个手动清cache的方式，通过 http 动态修改 be conf，可以立即清理掉cache并禁用
curl -X POST http://xxxx:8040/api/update_config?disable_storage_page_cache=true
再动态把 disable_storage_page_cache=false，就可以重新启用cache，是之前看内存问题用户的诉求，clickhouse可以直接通过 SQL 清cache，这里用http接口简单实现了下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956603493
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956246655
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956390810
TeamCity be ut coverage result:
Function Coverage: 35.71% (8556/23959)
Line Coverage: 27.59% (69403/251578)
Region Coverage: 26.72% (36012/134769)
Branch Coverage: 23.55% (18425/78246)
Coverage Report: http://coverage.selectdb-in.cc/coverage/49833999adb63ddeec6d0e6ffb804bc4bd0068bb_49833999adb63ddeec6d0e6ffb804bc4bd0068bb/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956227820
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #31220:
URL: https://github.com/apache/doris/pull/31220#discussion_r1497503521
##########
be/src/runtime/memory/cache_manager.h:
##########
@@ -54,9 +57,25 @@ class CacheManager {
void clear_once(CachePolicy::CacheType type);
+ bool need_prune(int64_t* last_timestamp, const std::string& type) {
Review Comment:
warning: method 'need_prune' can be made static [readability-convert-member-functions-to-static]
```suggestion
static bool need_prune(int64_t* last_timestamp, const std::string& type) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #31220:
URL: https://github.com/apache/doris/pull/31220#discussion_r1497487981
##########
be/src/olap/olap_server.cpp:
##########
@@ -287,6 +286,16 @@ void StorageEngine::_cache_clean_callback() {
} else {
_clear_segment_cache = false;
}
+ if (config::disable_storage_page_cache) {
Review Comment:
// Dynamically modify the config to clear the cache, each time the disable cache will only be cleared once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1958774847
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956642290
TeamCity be ut coverage result:
Function Coverage: 35.71% (8555/23959)
Line Coverage: 27.60% (69440/251620)
Region Coverage: 26.73% (36027/134779)
Branch Coverage: 23.55% (18426/78258)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fc85b16ad962937379c38c7ccbfeef3619f8e981_fc85b16ad962937379c38c7ccbfeef3619f8e981/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956683550
<details>
<summary>TPC-DS: <b>Total hot run time: 177998 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fc85b16ad962937379c38c7ccbfeef3619f8e981, data reload: false
query1 944 358 348 348
query2 6520 1732 1791 1732
query3 6690 206 205 205
query4 23027 21133 21247 21133
query5 4276 382 379 379
query6 262 196 172 172
query7 4608 305 300 300
query8 256 202 206 202
query9 8461 2941 2942 2941
query10 423 242 234 234
query11 15006 14509 14495 14495
query12 149 86 85 85
query13 1721 436 440 436
query14 9844 7723 7787 7723
query15 209 195 202 195
query16 7613 256 252 252
query17 1395 560 543 543
query18 1955 272 267 267
query19 193 143 148 143
query20 88 83 87 83
query21 192 132 124 124
query22 4956 4788 4704 4704
query23 32458 31661 31518 31518
query24 12736 3451 3454 3451
query25 662 361 358 358
query26 1884 163 169 163
query27 3042 328 319 319
query28 6586 1905 1898 1898
query29 1138 639 651 639
query30 287 140 148 140
query31 955 762 763 762
query32 100 58 59 58
query33 720 240 229 229
query34 1086 500 504 500
query35 933 836 860 836
query36 1020 863 922 863
query37 174 61 64 61
query38 3311 3161 3176 3161
query39 1404 1325 1324 1324
query40 285 107 104 104
query41 38 37 35 35
query42 117 98 99 98
query43 481 461 461 461
query44 1081 703 714 703
query45 199 181 183 181
query46 1079 783 779 779
query47 1643 1541 1563 1541
query48 433 352 345 345
query49 1207 310 309 309
query50 775 379 389 379
query51 4437 4412 4299 4299
query52 114 91 99 91
query53 396 323 310 310
query54 307 208 226 208
query55 80 82 82 82
query56 226 201 198 198
query57 1025 963 976 963
query58 217 202 208 202
query59 2374 2351 2319 2319
query60 251 223 225 223
query61 83 85 83 83
query62 598 384 382 382
query63 340 294 289 289
query64 6250 3070 3112 3070
query65 3289 3300 3272 3272
query66 1342 340 324 324
query67 14794 14506 14402 14402
query68 5088 566 575 566
query69 544 383 377 377
query70 1326 1170 1220 1170
query71 450 249 261 249
query72 6259 2788 2617 2617
query73 724 312 312 312
query74 6972 6527 6451 6451
query75 3229 2603 2575 2575
query76 3304 1153 1214 1153
query77 378 248 235 235
query78 9536 8845 8823 8823
query79 963 522 508 508
query80 511 368 343 343
query81 438 204 207 204
query82 169 89 91 89
query83 145 125 122 122
query84 230 80 80 80
query85 995 379 348 348
query86 302 321 310 310
query87 3460 3315 3308 3308
query88 2750 2297 2304 2297
query89 446 386 355 355
query90 1868 168 165 165
query91 156 132 133 132
query92 55 55 53 53
query93 1023 523 504 504
query94 1134 180 188 180
query95 492 394 394 394
query96 578 264 261 261
query97 4467 4274 4315 4274
query98 222 210 206 206
query99 1108 752 709 709
Total cold run time: 270067 ms
Total hot run time: 177998 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #31220:
URL: https://github.com/apache/doris/pull/31220#discussion_r1497266038
##########
be/src/runtime/memory/cache_manager.h:
##########
@@ -54,9 +55,29 @@ class CacheManager {
void clear_once(CachePolicy::CacheType type);
+ template <bool prune_stale>
+ bool need_prune() {
Review Comment:
这里不要用模板参数，直接用函数的参数就行了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956227731
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956693963
<details>
<summary>ClickBench: <b>Total hot run time: 30.92 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fc85b16ad962937379c38c7ccbfeef3619f8e981, data reload: false
query1 0.04 0.02 0.03
query2 0.06 0.02 0.02
query3 0.24 0.08 0.07
query4 1.64 0.09 0.09
query5 0.50 0.50 0.49
query6 1.37 0.64 0.62
query7 0.02 0.01 0.01
query8 0.04 0.02 0.03
query9 0.53 0.47 0.46
query10 0.50 0.50 0.49
query11 0.13 0.10 0.10
query12 0.12 0.10 0.10
query13 0.59 0.58 0.59
query14 0.77 0.79 0.82
query15 0.82 0.81 0.80
query16 0.35 0.35 0.35
query17 0.93 0.94 0.96
query18 0.17 0.18 0.18
query19 1.74 1.67 1.75
query20 0.01 0.02 0.01
query21 15.40 0.67 0.62
query22 3.25 3.90 2.11
query23 17.63 1.10 0.95
query24 2.10 0.53 0.26
query25 0.60 0.08 0.06
query26 0.18 0.15 0.15
query27 0.05 0.05 0.06
query28 12.03 0.85 0.84
query29 12.59 3.30 3.37
query30 0.55 0.49 0.50
query31 2.80 0.37 0.38
query32 3.31 0.48 0.48
query33 3.13 3.22 3.17
query34 15.37 4.53 4.55
query35 4.53 4.48 4.51
query36 1.09 0.96 0.99
query37 0.07 0.06 0.05
query38 0.05 0.03 0.04
query39 0.03 0.02 0.02
query40 0.18 0.15 0.15
query41 0.07 0.01 0.02
query42 0.03 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 105.64 s
Total hot run time: 30.92 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #31220:
URL: https://github.com/apache/doris/pull/31220#discussion_r1497267447
##########
be/src/olap/olap_server.cpp:
##########
@@ -287,6 +286,16 @@ void StorageEngine::_cache_clean_callback() {
} else {
_clear_segment_cache = false;
}
+ if (config::disable_storage_page_cache) {
Review Comment:
为啥是在disable page cache的时候去clear 呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31220:
URL: https://github.com/apache/doris/pull/31220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1956660873
<details>
<summary>TPC-H: <b>Total hot run time: 41828 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fc85b16ad962937379c38c7ccbfeef3619f8e981, data reload: false
------ Round 1 ----------------------------------
q1 17699 5107 4988 4988
q2 2040 149 133 133
q3 10579 1059 1005 1005
q4 4651 982 992 982
q5 7696 3268 3302 3268
q6 200 142 141 141
q7 1278 796 774 774
q8 9275 2086 2076 2076
q9 7592 6724 6712 6712
q10 8324 2661 2626 2626
q11 421 217 215 215
q12 793 342 342 342
q13 18003 3718 3723 3718
q14 296 269 269 269
q15 601 526 506 506
q16 496 432 441 432
q17 939 875 846 846
q18 7585 6604 6808 6604
q19 1545 1514 1503 1503
q20 638 360 329 329
q21 6854 4038 4005 4005
q22 900 354 355 354
Total cold run time: 108405 ms
Total hot run time: 41828 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4971 4934 4963 4934
q2 296 192 194 192
q3 3653 3622 3626 3622
q4 2604 2611 2577 2577
q5 5868 5828 5846 5828
q6 215 132 136 132
q7 2313 1701 1722 1701
q8 3130 3184 3227 3184
q9 8876 8832 8867 8832
q10 6917 4324 4291 4291
q11 555 413 408 408
q12 807 575 576 575
q13 4299 3557 3518 3518
q14 267 254 239 239
q15 659 518 547 518
q16 519 469 454 454
q17 1742 1769 1660 1660
q18 8447 8385 8422 8385
q19 1686 1675 1682 1675
q20 2177 1881 1903 1881
q21 6916 6646 6458 6458
q22 591 545 542 542
Total cold run time: 67508 ms
Total hot run time: 61606 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31220:
URL: https://github.com/apache/doris/pull/31220#issuecomment-1958774809
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) Fix LRU cache frequent prune [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #31220:
URL: https://github.com/apache/doris/pull/31220#discussion_r1497487498
##########
be/src/runtime/memory/cache_manager.h:
##########
@@ -54,9 +55,29 @@ class CacheManager {
void clear_once(CachePolicy::CacheType type);
+ template <bool prune_stale>
+ bool need_prune() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org